Implement initial chrome.browserAction.openPopup API.

chrome/browser/extensions/api/extension_action/extension_action_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
 
-#include <string>
+#include <set>

[Finnur, 2013/10/15 10:44:21]

Where's std::set used?

[justinlin, 2013/10/16 07:06:48]

Done.

 
 #include "base/base64.h"
 #include "base/lazy_instance.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/values.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/api/extension_action/extension_page_actions_api_constants.h"
 #include "chrome/browser/extensions/event_router.h"
 #include "chrome/browser/extensions/extension_action.h"
 #include "chrome/browser/extensions/extension_action_manager.h"
 #include "chrome/browser/extensions/extension_function_registry.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/extensions/location_bar_controller.h"
 #include "chrome/browser/extensions/state_store.h"
 #include "chrome/browser/extensions/tab_helper.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/api/extension_action/action_info.h"
+#include "chrome/common/extensions/features/simple_feature.h"

[Finnur, 2013/10/15 10:44:21]

Don't need this?

[justinlin, 2013/10/16 07:06:48]

Done.

 #include "chrome/common/render_messages.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/notification_service.h"
 #include "extensions/common/error_utils.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/image/image_skia.h"
 
+using chrome::VersionInfo;

[Finnur, 2013/10/15 10:44:21]

Don't need this, right?

[justinlin, 2013/10/16 07:06:48]

Done.

 using content::WebContents;
 
 namespace page_actions_keys = extension_page_actions_api_constants;
 
 namespace extensions {
 
 namespace {
 
 const char kBrowserActionStorageKey[] = "browser_action";
 const char kPopupUrlStorageKey[] = "poupup_url";
@@ skipping 157 matching lines @@
   registry->RegisterFunction<BrowserActionSetTitleFunction>();
   registry->RegisterFunction<BrowserActionSetBadgeTextFunction>();
   registry->RegisterFunction<BrowserActionSetBadgeBackgroundColorFunction>();
   registry->RegisterFunction<BrowserActionSetPopupFunction>();
   registry->RegisterFunction<BrowserActionGetTitleFunction>();
   registry->RegisterFunction<BrowserActionGetBadgeTextFunction>();
   registry->RegisterFunction<BrowserActionGetBadgeBackgroundColorFunction>();
   registry->RegisterFunction<BrowserActionGetPopupFunction>();
   registry->RegisterFunction<BrowserActionEnableFunction>();
   registry->RegisterFunction<BrowserActionDisableFunction>();
+  registry->RegisterFunction<BrowserActionOpenPopupFunction>();
 
   // Page Actions
   registry->RegisterFunction<EnablePageActionsFunction>();
   registry->RegisterFunction<DisablePageActionsFunction>();
   registry->RegisterFunction<PageActionShowFunction>();
   registry->RegisterFunction<PageActionHideFunction>();
   registry->RegisterFunction<PageActionSetIconFunction>();
   registry->RegisterFunction<PageActionSetTitleFunction>();
   registry->RegisterFunction<PageActionSetPopupFunction>();
   registry->RegisterFunction<PageActionGetTitleFunction>();
@@ skipping 576 matching lines @@
   list->Append(
       new base::FundamentalValue(static_cast<int>(SkColorGetG(color))));
   list->Append(
       new base::FundamentalValue(static_cast<int>(SkColorGetB(color))));
   list->Append(
       new base::FundamentalValue(static_cast<int>(SkColorGetA(color))));
   SetResult(list);
   return true;
 }
 
+bool BrowserActionOpenPopupFunction::RunImpl() {
+  ExtensionService* service =
+      extensions::ExtensionSystem::Get(profile_)->extension_service();
+  if (!service) {
+    SetResult(new base::DictionaryValue());
+    return false;

[Finnur, 2013/10/15 10:44:21]

Do you see these (service and model below) being NULL at some point?

[justinlin, 2013/10/16 07:06:48]

yea, I think extension_service() would not be NULL since there's a lot of
unprotected calls for that, but leaving the check for model

+  }
+
+  ExtensionToolbarModel *model = service->toolbar_model();

[Finnur, 2013/10/15 10:44:21]

Foo* foo 
not
Foo *foo.

[justinlin, 2013/10/16 07:06:48]

Done.

+  if (!model) {
+    SetResult(new base::DictionaryValue());
+    return false;
+  }
+
+  model->ShowBrowserActionPopup(extension_);
+
+  SetResult(new base::DictionaryValue());
+  return true;
+}
+
 //
 // ScriptBadgeGetAttentionFunction
 //
 
 ScriptBadgeGetAttentionFunction::~ScriptBadgeGetAttentionFunction() {}
 
 bool ScriptBadgeGetAttentionFunction::RunExtensionAction() {
   tab_helper().location_bar_controller()->GetAttentionFor(extension_id());
   return true;
 }
@@ skipping 66 matching lines @@
   return true;
 }
 
 bool EnablePageActionsFunction::RunImpl() {
   return SetPageActionEnabled(true);
 }
 
 bool DisablePageActionsFunction::RunImpl() {
   return SetPageActionEnabled(false);
 }