Implement initial chrome.browserAction.openPopup API.

chrome/browser/ui/views/browser_actions_container.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/browser_actions_container.h"
 
 #include "base/compiler_specific.h"
 #include "base/prefs/pref_service.h"
 #include "base/stl_util.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 668 matching lines @@
     index = model_->OriginalIndexToIncognito(index);
 
   DCHECK(index >= 0 && index < static_cast<int>(browser_action_views_.size()));
 
   DeleteBrowserActionViews();
   CreateBrowserActionViews();
   Layout();
   SchedulePaint();
 }
 
+void BrowserActionsContainer::BrowserActionShowPopup(
+    const extensions::Extension* extension) {
+  // DO_NOT_REVIEW: This is not completely correct yet.
+  BrowserActionButton* button = NULL;
+  for (BrowserActionViews::iterator it = browser_action_views_.begin();
+       it != browser_action_views_.end(); ++it) {
+    if ((*it)->button()->extension() == extension) {
+      button = (*it)->button();
+    }
+  }
+  if (button != NULL)
+    ShowPopup(button, ExtensionPopup::SHOW);
+}
+
 void BrowserActionsContainer::ModelLoaded() {
   SetContainerWidth();
 }
 
 void BrowserActionsContainer::LoadImages() {
   ui::ThemeProvider* tp = GetThemeProvider();
   chevron_->SetIcon(*tp->GetImageSkiaNamed(IDR_BROWSER_ACTIONS_OVERFLOW));
   chevron_->SetHoverIcon(*tp->GetImageSkiaNamed(
       IDR_BROWSER_ACTIONS_OVERFLOW_H));
   chevron_->SetPushedIcon(*tp->GetImageSkiaNamed(
@@ skipping 109 matching lines @@
   // Only display incognito-enabled extensions while in incognito mode.
   return
       (!profile_->IsOffTheRecord() ||
        extensions::ExtensionSystem::Get(profile_)->extension_service()->
            IsIncognitoEnabled(extension->id()));
 }
 
 void BrowserActionsContainer::ShowPopup(
     BrowserActionButton* button,
     ExtensionPopup::ShowAction show_action) {
-  const Extension* extension = button->extension();
+  const extensions::Extension* extension = button->extension();

[Matt Perry, 2013/10/11 22:22:53]

Why add this?

[justinlin, 2013/10/16 07:06:48]

Done.

   GURL popup_url;
   if (model_->ExecuteBrowserAction(extension, browser_, &popup_url) !=
       ExtensionToolbarModel::ACTION_SHOW_POPUP) {
     return;
   }
 
   // If we're showing the same popup, just hide it and return.
   bool same_showing = popup_ && button == popup_button_;
 
   // Always hide the current popup, even if it's not the same.
@@ skipping 11 matching lines @@
       views::BubbleBorder::TOP_LEFT : views::BubbleBorder::TOP_RIGHT;
   popup_ = ExtensionPopup::ShowPopup(popup_url,
                                      browser_,
                                      reference_view,
                                      arrow,
                                      show_action);
   popup_->GetWidget()->AddObserver(this);
   popup_button_ = button;
   popup_button_->SetButtonPushed();
 }