Implement initial chrome.browserAction.openPopup API.

chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/browser_actions_controller.h"
 
 #include <cmath>
 #include <string>
 
 #include "base/prefs/pref_service.h"
@@ skipping 122 matching lines @@
 
 // Moves the given button both visually and within the toolbar model to the
 // specified index.
 - (void)moveButton:(BrowserActionButton*)button
            toIndex:(NSUInteger)index
            animate:(BOOL)animate;
 
 // Handles when the given BrowserActionButton object is clicked.
 - (void)browserActionClicked:(BrowserActionButton*)button;
 
+// Triggers opening the popup window for an extension without a user action.
+// Used by an extension API that opens an extension's popup.
+- (void)openPopup:(const Extension*)extension;
+
 // Returns whether the given extension should be displayed. Only displays
 // incognito-enabled extensions in incognito mode. Otherwise returns YES.
 - (BOOL)shouldDisplayBrowserAction:(const Extension*)extension;
 
 // The reason |frame| is specified in these chevron functions is because the
 // container may be animating and the end frame of the animation should be
 // passed instead of the current frame (which may be off and cause the chevron
 // to jump at the end of its animation).
 
 // Shows the overflow chevron button depending on whether there are any hidden
@@ skipping 78 matching lines @@
       int index) OVERRIDE {
     [owner_ createActionButtonForExtension:extension withIndex:index];
     [owner_ resizeContainerAndAnimate:NO];
   }
 
   virtual void BrowserActionRemoved(const Extension* extension) OVERRIDE {
     [owner_ removeActionButtonForExtension:extension];
     [owner_ resizeContainerAndAnimate:NO];
   }
 
+  virtual void BrowserActionShowPopup(const Extension* extension) OVERRIDE {
+    content::WebContents* active_tab =
+        browser_->tab_strip_model()->GetActiveWebContents();
+    if (!active_tab)
+      return;
+    [owner_ openPopup:extension];
+  }
+
  private:
   // The object we need to inform when we get a notification. Weak. Owns us.
   BrowserActionsController* owner_;
 
   // The browser we listen for events from. Weak.
   Browser* browser_;
 
   // Used for registering to receive notifications and automatic clean up.
   content::NotificationRegistrar registrar_;
 
@@ skipping 481 matching lines @@
       [button setAlphaValue:1.0];
       [hiddenButtons_ removeObjectIdenticalTo:button];
     }
   } else if (![hiddenButtons_ containsObject:button]) {
     [hiddenButtons_ addObject:button];
     [button removeFromSuperview];
     [button setAlphaValue:0.0];
   }
 }
 
+- (void)openPopup:(const Extension*)extension {
+  const GURL popupUrl = toolbarModel_->GetPopupUrl(extension, browser_);
+  if (!popupUrl.is_empty()) {
+    NSPoint arrowPoint = [self popupPointForBrowserAction:extension];
+    if (NSEqualPoints(arrowPoint, NSZeroPoint)) {
+      // The button is hidden if arrowPoint is zero.
+
+      // TODO(justinlin): This is not right.. position below hotdog menu.

[mark a. foltz, 2013/10/11 20:25:30]

When an extension is installed into the overflow bin it shows the popup bubble
below the hotdog menu ... I didn't see code in this class to handle that case
though.  Wonder where it lives - I couldn't find it.

[justinlin, 2013/10/16 07:06:48]

Right. It's a bit unclear how to plumb that in right now, so punting on that for
now. It should be seldom used anyway.

+      arrowPoint = NSMakePoint(NSWidth([containerView_ frame]),
+                               kBrowserActionOriginYOffset);
+    }
+
+    [ExtensionPopupController showURL:popupUrl
+                            inBrowser:browser_
+                           anchoredAt:arrowPoint
+                        arrowLocation:info_bubble::kTopRight
+                              devMode:NO];
+  }
+}
+
 - (void)browserActionClicked:(BrowserActionButton*)button {
   const Extension* extension = [button extension];
   GURL popupUrl;
   switch (toolbarModel_->ExecuteBrowserAction(extension, browser_, &popupUrl)) {
     case ExtensionToolbarModel::ACTION_NONE:
       break;
     case ExtensionToolbarModel::ACTION_SHOW_POPUP: {
       NSPoint arrowPoint = [self popupPointForBrowserAction:extension];
       [ExtensionPopupController showURL:popupUrl
                               inBrowser:browser_
@@ skipping 111 matching lines @@
   const extensions::ExtensionList& toolbar_items =
       toolbarModel_->toolbar_items();
   if (index < toolbar_items.size()) {
     const Extension* extension = toolbar_items[index].get();
     return [buttons_ objectForKey:base::SysUTF8ToNSString(extension->id())];
   }
   return nil;
 }
 
 @end