Implement initial chrome.browserAction.openPopup API.

chrome/browser/extensions/api/extension_action/extension_action_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
 
 #include <string>
 
 #include "base/base64.h"
 #include "base/lazy_instance.h"
@@ skipping 14 matching lines @@
 #include "chrome/browser/extensions/tab_helper.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/api/extension_action/action_info.h"
 #include "chrome/common/render_messages.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/notification_service.h"
 #include "extensions/common/error_utils.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/image/image_skia.h"
 
+#include "chrome/browser/ui/browser_finder.h"
+
 using content::WebContents;
 
 namespace page_actions_keys = extension_page_actions_api_constants;
 
 namespace extensions {
 
 namespace {
 
 const char kBrowserActionStorageKey[] = "browser_action";
 const char kPopupUrlStorageKey[] = "poupup_url";
@@ skipping 157 matching lines @@
   registry->RegisterFunction<BrowserActionSetTitleFunction>();
   registry->RegisterFunction<BrowserActionSetBadgeTextFunction>();
   registry->RegisterFunction<BrowserActionSetBadgeBackgroundColorFunction>();
   registry->RegisterFunction<BrowserActionSetPopupFunction>();
   registry->RegisterFunction<BrowserActionGetTitleFunction>();
   registry->RegisterFunction<BrowserActionGetBadgeTextFunction>();
   registry->RegisterFunction<BrowserActionGetBadgeBackgroundColorFunction>();
   registry->RegisterFunction<BrowserActionGetPopupFunction>();
   registry->RegisterFunction<BrowserActionEnableFunction>();
   registry->RegisterFunction<BrowserActionDisableFunction>();
+  registry->RegisterFunction<BrowserActionOpenPopupFunction>();
 
   // Page Actions
   registry->RegisterFunction<EnablePageActionsFunction>();
   registry->RegisterFunction<DisablePageActionsFunction>();
   registry->RegisterFunction<PageActionShowFunction>();
   registry->RegisterFunction<PageActionHideFunction>();
   registry->RegisterFunction<PageActionSetIconFunction>();
   registry->RegisterFunction<PageActionSetTitleFunction>();
   registry->RegisterFunction<PageActionSetPopupFunction>();
   registry->RegisterFunction<PageActionGetTitleFunction>();
@@ skipping 576 matching lines @@
   list->Append(
       new base::FundamentalValue(static_cast<int>(SkColorGetG(color))));
   list->Append(
       new base::FundamentalValue(static_cast<int>(SkColorGetB(color))));
   list->Append(
       new base::FundamentalValue(static_cast<int>(SkColorGetA(color))));
   SetResult(list);
   return true;
 }
 
+bool BrowserActionOpenPopupFunction::RunImpl() {
+  Browser* browser =
+      chrome::FindOrCreateTabbedBrowser(profile_, chrome::GetActiveDesktop());

[mark a. foltz, 2013/10/07 22:08:14]

Need to decide which window gets the popup.
  
- Would FindLastActiveWithProfile be more appropriate?
- Should we create a new browser window if one does not exist?
- Do we need any handling of incognito mode profiles?  

[justinlin, 2013/10/09 18:19:32]

Yes, we should use the last active.
I don't think so. Seems like if would be non-user-initiated anyway if we somehow
need to popup it up when there's no window.
Depends on the platform, but yes we should pop it up in the incognito window if
that was the last one focused.

+  std::pair<const std::string, void* /*gfx::NativeWindow*/> details =
+      std::make_pair(extension_id(), browser/*browser->window()->GetNativeWindow()*/);
+  content::NotificationService::current()->Notify(

[mark a. foltz, 2013/10/07 22:08:14]

It looks like only the Mac UI handles this notification... I wonder if we need
to port that code to the other platforms.

[justinlin, 2013/10/09 18:19:32]

Using an observer notification instead now.

+      chrome::NOTIFICATION_EXTENSION_COMMAND_BROWSER_ACTION_MAC,
+      content::Source<Profile>(profile_),
+      content::Details<
+          std::pair<const std::string, void* /*gfx::NativeWindow*/> >(&details));
+  return true;
+}
+
 //
 // ScriptBadgeGetAttentionFunction
 //
 
 ScriptBadgeGetAttentionFunction::~ScriptBadgeGetAttentionFunction() {}
 
 bool ScriptBadgeGetAttentionFunction::RunExtensionAction() {
   tab_helper().location_bar_controller()->GetAttentionFor(extension_id());
   return true;
 }
@@ skipping 66 matching lines @@
   return true;
 }
 
 bool EnablePageActionsFunction::RunImpl() {
   return SetPageActionEnabled(true);
 }
 
 bool DisablePageActionsFunction::RunImpl() {
   return SetPageActionEnabled(false);
 }