Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Unified Diff: media/gpu/v4l2_video_decode_accelerator.h

Issue 2530493003: V4L2VDA: do not allocate input buffers in GPU child thread. (Closed)
Patch Set: address Kuang-che's comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/gpu/v4l2_video_decode_accelerator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/gpu/v4l2_video_decode_accelerator.h
diff --git a/media/gpu/v4l2_video_decode_accelerator.h b/media/gpu/v4l2_video_decode_accelerator.h
index 208fa70b94df9201859e7a3e3dd18859a4cb18e4..dc3baf295baa3013bb7dcc761c9bbce6a4564ed6 100644
--- a/media/gpu/v4l2_video_decode_accelerator.h
+++ b/media/gpu/v4l2_video_decode_accelerator.h
@@ -136,7 +136,7 @@ class MEDIA_GPU_EXPORT V4L2VideoDecodeAccelerator
// Internal state of the decoder.
enum State {
kUninitialized, // Initialize() not yet called.
- kInitialized, // Initialize() returned true; ready to start decoding.
+ kInitialized, // InitializeTask() succeeds; ready to start decoding.
kcwu 2016/11/29 03:51:46 this is still "Initialize() returned true"
wuchengli 2016/11/29 05:18:22 Done.
kDecoding, // DecodeBufferInitial() successful; decoding frames.
kResetting, // Presently resetting.
// Performing resolution change and waiting for image processor to return
@@ -202,6 +202,9 @@ class MEDIA_GPU_EXPORT V4L2VideoDecodeAccelerator
// Decoding tasks, to be run on decode_thread_.
//
+ // Task to finish initialization on decoder_thread_.
+ void InitializeTask();
+
// Enqueue a BitstreamBuffer to decode. This will enqueue a buffer to the
// decoder_input_queue_, then queue a DecodeBufferTask() to actually decode
// the buffer.
« no previous file with comments | « no previous file | media/gpu/v4l2_video_decode_accelerator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698