Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2530443003:
Cleanup tests for minimizing ARC++ windows on startup. (Closed)
DescriptionCleanup tests for minimizing ARC++ windows on startup.
Follow up for: https://codereview.chromium.org/2517833003/
TEST=exo_unittests
BUG=667608
Committed: https://crrev.com/bbef4b39c24bd1a94e3b66158a20af4b607f5090
Cr-Commit-Position: refs/heads/master@{#434622}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Updated the test. #Messages
Total messages: 17 (11 generated)
The CQ bit was checked by mtomasz@chromium.org to run a CQ dry run
Description was changed from ========== Cleanup tests for minimizing ARC++ windows on startup. Follow up for: https://codereview.chromium.org/2517833003/ TEST=exo_unittests BUG=667608 ========== to ========== Cleanup tests for minimizing ARC++ windows on startup. Follow up for: https://codereview.chromium.org/2517833003/ TEST=exo_unittests BUG=667608 ==========
mtomasz@chromium.org changed reviewers: + reveman@chromium.org
@reveman: PTAL, thx.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
lgtm % nit https://codereview.chromium.org/2530443003/diff/1/components/exo/shell_surfac... File components/exo/shell_surface_unittest.cc (right): https://codereview.chromium.org/2530443003/diff/1/components/exo/shell_surfac... components/exo/shell_surface_unittest.cc:139: EXPECT_FALSE(shell_surface->GetWidget()->IsMinimized()); nit: after this, can you also: shell_surface->Minimize(); EXPECT_TRUE(shell_surface->GetWidget()->IsMinimized());
https://codereview.chromium.org/2530443003/diff/1/components/exo/shell_surfac... File components/exo/shell_surface_unittest.cc (right): https://codereview.chromium.org/2530443003/diff/1/components/exo/shell_surfac... components/exo/shell_surface_unittest.cc:139: EXPECT_FALSE(shell_surface->GetWidget()->IsMinimized()); On 2016/11/25 21:38:54, reveman wrote: > nit: after this, can you also: > shell_surface->Minimize(); > EXPECT_TRUE(shell_surface->GetWidget()->IsMinimized()); Done.
The CQ bit was checked by mtomasz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from reveman@chromium.org Link to the patchset: https://codereview.chromium.org/2530443003/#ps20001 (title: "Updated the test.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480323714193270,
"parent_rev": "1f39b090038c939d239765bc232000b6b7a33831", "commit_rev":
"ac1778743fbc14050881e2e0e865c7143cfcdcac"}
Message was sent while issue was closed.
Description was changed from ========== Cleanup tests for minimizing ARC++ windows on startup. Follow up for: https://codereview.chromium.org/2517833003/ TEST=exo_unittests BUG=667608 ========== to ========== Cleanup tests for minimizing ARC++ windows on startup. Follow up for: https://codereview.chromium.org/2517833003/ TEST=exo_unittests BUG=667608 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Cleanup tests for minimizing ARC++ windows on startup. Follow up for: https://codereview.chromium.org/2517833003/ TEST=exo_unittests BUG=667608 ========== to ========== Cleanup tests for minimizing ARC++ windows on startup. Follow up for: https://codereview.chromium.org/2517833003/ TEST=exo_unittests BUG=667608 Committed: https://crrev.com/bbef4b39c24bd1a94e3b66158a20af4b607f5090 Cr-Commit-Position: refs/heads/master@{#434622} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/bbef4b39c24bd1a94e3b66158a20af4b607f5090 Cr-Commit-Position: refs/heads/master@{#434622} |
