[SPv2] PaintArtifactorCompositor needs to set target_effect_id for root clip

[SPv2] PaintArtifactorCompositor needs to set target_effect_id for root clip

Today we still cache many render surface clip properties in clip nodes, thus
each clip node needs to associate with an effect node. This restriction may
be lifted in the future but today we just blindly assign root surface to it.

BUG=667996
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/635d7eed3b226d51cfbce4a0863de02a0ac52ce3
Cr-Commit-Position: refs/heads/master@{#434224}

[trchen, 2016-11-23 03:44:45]

Description was changed from

==========
[SPv2] PaintArtifactorCompositor needs to set target_effect_id for root clip

Today we still cache many render surface clip properties in clip nodes, thus
each clip node needs to associate with an effect node. This restriction may
be lifted in the future but today we just blindly assign root surface to it.

BUG=667996
==========

to

==========
[SPv2] PaintArtifactorCompositor needs to set target_effect_id for root clip

Today we still cache many render surface clip properties in clip nodes, thus
each clip node needs to associate with an effect node. This restriction may
be lifted in the future but today we just blindly assign root surface to it.

BUG=667996
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[trchen, 2016-11-23 03:44:58]

trchen@chromium.org changed reviewers:
+ pdr@chromium.org

[trchen, 2016-11-23 03:45:03]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 03:45:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2016-11-23 03:47:37]

On 2016/11/23 at 03:44:59, trchen wrote:
> 

LGTM

Curious: do you know why this is different for the root-layer-scrolls case?

[trchen, 2016-11-23 04:00:25]

On 2016/11/23 03:47:37, pdr. wrote:
> On 2016/11/23 at 03:44:59, trchen wrote:
> > 
> 
> LGTM
> 
> Curious: do you know why this is different for the root-layer-scrolls case?

I didn't dump the display item list, but I believe it's the root background.

Without RLS, the frame clip is a FrameView clip thus is included in LayoutView's
local border box context, and root background paint with it.

With RLS, the frame clip is LayoutView's overflow clip, thus not included in
LayoutView's local border box context, and root background paint with root clip.

Yea, I think it's not quite right. We should include LayoutView's overflow clip
earlier in PaintLayerPainter as a special case. I'll file a bug for myself.

[commit-bot: I haz the power, 2016-11-23 04:59:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 04:59:29]

Dry run: This issue passed the CQ dry run.

[trchen, 2016-11-23 19:27:09]

The CQ bit was checked by trchen@chromium.org

[commit-bot: I haz the power, 2016-11-23 19:27:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 19:40:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479929229832830, "parent_rev":
"94073ad86608f1d38de535ebd923b68b992be2ae", "commit_rev":
"1b46aabf9ecae94eb2196f96c852b51b122d41ad"}

[commit-bot: I haz the power, 2016-11-23 19:41:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-23 19:42:47]

Description was changed from

==========
[SPv2] PaintArtifactorCompositor needs to set target_effect_id for root clip

Today we still cache many render surface clip properties in clip nodes, thus
each clip node needs to associate with an effect node. This restriction may
be lifted in the future but today we just blindly assign root surface to it.

BUG=667996
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[SPv2] PaintArtifactorCompositor needs to set target_effect_id for root clip

Today we still cache many render surface clip properties in clip nodes, thus
each clip node needs to associate with an effect node. This restriction may
be lifted in the future but today we just blindly assign root surface to it.

BUG=667996
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/635d7eed3b226d51cfbce4a0863de02a0ac52ce3
Cr-Commit-Position: refs/heads/master@{#434224}
==========

[commit-bot: I haz the power, 2016-11-23 19:42:47]

Patchset 1 (id:??) landed as
https://crrev.com/635d7eed3b226d51cfbce4a0863de02a0ac52ce3
Cr-Commit-Position: refs/heads/master@{#434224}