Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2530423002:
Check the Nougat version code in the supported way (Closed)
|
Created:
4 years ago by Miguel Garcia Modified:
4 years ago Reviewers:
johnme CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, agrieve+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCheck the Nougat version code in the supported way
BUG=
Committed: https://crrev.com/078a1f3b70994fbad1d60b3d335741058c04467d
Cr-Commit-Position: refs/heads/master@{#434651}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 15 (8 generated)
The CQ bit was checked by miguelg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
miguelg@chromium.org changed reviewers: + johnme@chromium.org
https://codereview.chromium.org/2530423002/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java (right): https://codereview.chromium.org/2530423002/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java:636: if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) { This will fail to detect devices stuck on early N developer preview builds[1]. For past versions of Android that was only a few Googlers, but N had a public developer preview, so there might be a few actual users on such builds. Is there a benefit to moving to this shorter form? [1]: https://commonsware.com/blog/2016/03/17/backwards-compatibility-n-developer-p...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm if you think the simplification is worth it though, as it should be a very small number of users.
Yeah the rest of the code seems to have moved to that (or at least has TODOs to move :) ) so probably ok to break dev previews https://cs.chromium.org/search/?q=Build.VERSION_CODES.N&sq=package:chromium&t... On Mon, Nov 28, 2016 at 1:54 PM, <johnme@chromium.org> wrote: > > https://codereview.chromium.org/2530423002/diff/1/chrome/and > roid/java/src/org/chromium/chrome/browser/notifications/Noti > ficationPlatformBridge.java > File > chrome/android/java/src/org/chromium/chrome/browser/notifica > tions/NotificationPlatformBridge.java > (right): > > https://codereview.chromium.org/2530423002/diff/1/chrome/and > roid/java/src/org/chromium/chrome/browser/notifications/Noti > ficationPlatformBridge.java#newcode636 > chrome/android/java/src/org/chromium/chrome/browser/notifica > tions/NotificationPlatformBridge.java:636: > if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) { > This will fail to detect devices stuck on early N developer preview > builds[1]. For past versions of Android that was only a few Googlers, > but N had a public developer preview, so there might be a few actual > users on such builds. Is there a benefit to moving to this shorter form? > > [1]: > https://commonsware.com/blog/2016/03/17/backwards-compatibil > ity-n-developer-preview.html > > https://codereview.chromium.org/2530423002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by miguelg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480342036442340, "parent_rev":
"98b605aa86db0282584be74e0f45ca75dd306bfa", "commit_rev":
"4511c8a34ec02ffa0f9129c196ff6e11afd00bc8"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Check the Nougat version code in the supported way BUG= ========== to ========== Check the Nougat version code in the supported way BUG= Committed: https://crrev.com/078a1f3b70994fbad1d60b3d335741058c04467d Cr-Commit-Position: refs/heads/master@{#434651} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/078a1f3b70994fbad1d60b3d335741058c04467d Cr-Commit-Position: refs/heads/master@{#434651} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
