Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2530383003: [heap] Reland: Use store buffer for writes coming from mutator. (Closed)

Created:
4 years ago by Hannes Payer (out of office)
Modified:
4 years ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland: Use store buffer for writes coming from mutator. This reverts commit 810fcb2866d265266b24515ff2d9348425c63aef. BUG=chromium:648568, chromium:669270 Committed: https://crrev.com/f3d119b9c5bb39ba994a6e437bfdacff9a6ff8fc Cr-Commit-Position: refs/heads/master@{#41350}

Patch Set 1 #

Patch Set 2 : add more no barriers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -21 lines) Patch
M src/heap/heap.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M src/heap/heap-inl.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/heap/store-buffer.h View 3 chunks +19 lines, -1 line 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +21 lines, -7 lines 0 comments Download
M src/objects-inl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Michael Lippautz
lgtm
4 years ago (2016-11-29 10:19:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530383003/20001
4 years ago (2016-11-29 11:53:53 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 11:55:58 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-29 11:57:37 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f3d119b9c5bb39ba994a6e437bfdacff9a6ff8fc
Cr-Commit-Position: refs/heads/master@{#41350}

Powered by Google App Engine
This is Rietveld 408576698