Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5627)

Unified Diff: chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

Issue 2530353002: Views: Add a11y information for IconLabelBubbleView and LocationIconView. (Closed)
Patch Set: Use views::Label::GetAccessibleNodeData() for IconLabelBubbleView. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
diff --git a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
index 9d1812a681cfa1098835587e146c376161d064fd..d6313c7ddf13542d5c40f7c9ed079518f8663e04 100644
--- a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
+++ b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h
@@ -67,12 +67,13 @@ class IconLabelBubbleView : public views::InkDropHostView {
// true if some handling was performed.
virtual bool OnActivate(const ui::Event& event);
- // views::View:
+ // views::InkDropHostView:
tapted 2016/11/29 03:22:51 this should still be View - we name the class that
Patti Lor 2016/11/30 05:11:34 Done - thanks, I was a little confused about this.
gfx::Size GetPreferredSize() const override;
void Layout() override;
bool OnKeyPressed(const ui::KeyEvent& event) override;
bool OnKeyReleased(const ui::KeyEvent& event) override;
void OnNativeThemeChanged(const ui::NativeTheme* native_theme) override;
+ void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
void AddInkDropLayer(ui::Layer* ink_drop_layer) override;
tapted 2016/11/29 03:22:51 However, there should be a comment before this --
Patti Lor 2016/11/30 05:11:34 Done.
void RemoveInkDropLayer(ui::Layer* ink_drop_layer) override;
std::unique_ptr<views::InkDropHighlight> CreateInkDropHighlight()
« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698