Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 2530343005: Hide notification tray when the user flow doesn't allow (Closed)

Created:
4 years ago by yoshiki
Modified:
4 years ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide notification tray when the user flow doesn't allow This patch hides the notification tray in the status bar when the user flow doesn't allow. The patch is the follow-up of crrev.com/432116, because the previous patch was not enough. BUG=657934 TEST=manual test (confirm no notification tray on supervised user creation flow) Committed: https://crrev.com/88e6584140c183a90ad9aaab88daa8d41f146f6b Committed: https://crrev.com/6d276665acabcc6b5ba78ab7330b2fbf7b3cd389 Cr-Commit-Position: refs/heads/master@{#436509}

Patch Set 1 #

Patch Set 2 : Add a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
M ash/common/system/web_notification/web_notification_tray.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_browsertest.cc View 1 3 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
yoshiki
Oshima-san, PTAL.
4 years ago (2016-11-29 18:33:55 UTC) #8
oshima
can you add a unit test?
4 years ago (2016-11-30 17:37:24 UTC) #9
yoshiki
Oshima-san, I added a test. PTAL again?
4 years ago (2016-12-05 17:20:33 UTC) #14
oshima
lgtm thanks!
4 years ago (2016-12-05 20:12:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530343005/20001
4 years ago (2016-12-06 03:18:53 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 03:22:58 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-06 03:25:27 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6d276665acabcc6b5ba78ab7330b2fbf7b3cd389
Cr-Commit-Position: refs/heads/master@{#436509}

Powered by Google App Engine
This is Rietveld 408576698