enable skia gradients, fix bugs

enable skia gradients, fix bugs

Allow shading to use Skia for some gradients;
linear, radial, and coons patch.

The corpus uncovered a few gradient-related bugs
in the Skia driver which are fixed as well.

Fix corpus 11.pdf by ignoring zero area
filled paths. PDFium uses CFX_PathData::GetZeroAreaPath()
to determine if a path that doesn't enclosing anything
should be drawn anyway, and CFX_AggDeviceDriver::GetDriverType()
returns 1 so that the empty path is tweaked so that
it doesn't draw too often.

There are no tests in the corpus that show
the utility of this approach; 11.pdf draws correctly
if the zero area paths are ignored.

Standardize debugging output so that
a separate tool can visualize it.

R=dsinclair@chromium.org, thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/d65fd10e080751e42b9ea2696ae3f4e54839461c

[caryclark, 2016-11-30 13:43:21]

Description was changed from

==========
wip; skia debugging

BUG=
==========

to

==========
enable skia gradients, fix bugs

Allow shading to use Skia for some gradients.

The corpus uncovered a few gradient-related bugs
in the Skia driver which are fixed as well.

Fix corpus 11.pdf by ignoring zero area
filled paths. PDFium uses CFX_PathData::GetZeroAreaPath()
to determine if a path that doesn't enclosing anything
should be drawn anyway, and CFX_AggDeviceDriver::GetDriverType()
returns 1 so that the empty path is tweaked so that
it doesn't draw too often.

There are no tests in the corpus that show
the utility of this approach; 11.pdf draws correctly
if the zero area paths are ignored.

Standardize debugging output so that
a separate tool can visualize it.

R=dsinclair@chromium.org
==========

[caryclark, 2016-11-30 13:43:21]

caryclark@google.com changed reviewers:
+ dsinclair@chromium.org

[caryclark, 2016-11-30 13:43:30]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 13:43:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caryclark, 2016-11-30 13:46:59]

Description was changed from

==========
enable skia gradients, fix bugs

Allow shading to use Skia for some gradients.

The corpus uncovered a few gradient-related bugs
in the Skia driver which are fixed as well.

Fix corpus 11.pdf by ignoring zero area
filled paths. PDFium uses CFX_PathData::GetZeroAreaPath()
to determine if a path that doesn't enclosing anything
should be drawn anyway, and CFX_AggDeviceDriver::GetDriverType()
returns 1 so that the empty path is tweaked so that
it doesn't draw too often.

There are no tests in the corpus that show
the utility of this approach; 11.pdf draws correctly
if the zero area paths are ignored.

Standardize debugging output so that
a separate tool can visualize it.

R=dsinclair@chromium.org
==========

to

==========
enable skia gradients, fix bugs

Allow shading to use Skia for some gradients.

The corpus uncovered a few gradient-related bugs
in the Skia driver which are fixed as well.

Fix corpus 11.pdf by ignoring zero area
filled paths. PDFium uses CFX_PathData::GetZeroAreaPath()
to determine if a path that doesn't enclosing anything
should be drawn anyway, and CFX_AggDeviceDriver::GetDriverType()
returns 1 so that the empty path is tweaked so that
it doesn't draw too often.

There are no tests in the corpus that show
the utility of this approach; 11.pdf draws correctly
if the zero area paths are ignored.

Standardize debugging output so that
a separate tool can visualize it.

R=dsinclair@chromium.org, thestig@chromium.org
==========

[caryclark, 2016-11-30 13:47:00]

caryclark@google.com changed reviewers:
+ thestig@chromium.org

[caryclark, 2016-11-30 13:51:09]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 13:51:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 14:11:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 14:11:08]

Dry run: This issue passed the CQ dry run.

[caryclark, 2016-11-30 14:20:33]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 14:20:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 14:35:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 14:35:28]

Dry run: This issue passed the CQ dry run.

[caryclark, 2016-11-30 18:36:15]

Description was changed from

==========
enable skia gradients, fix bugs

Allow shading to use Skia for some gradients.

The corpus uncovered a few gradient-related bugs
in the Skia driver which are fixed as well.

Fix corpus 11.pdf by ignoring zero area
filled paths. PDFium uses CFX_PathData::GetZeroAreaPath()
to determine if a path that doesn't enclosing anything
should be drawn anyway, and CFX_AggDeviceDriver::GetDriverType()
returns 1 so that the empty path is tweaked so that
it doesn't draw too often.

There are no tests in the corpus that show
the utility of this approach; 11.pdf draws correctly
if the zero area paths are ignored.

Standardize debugging output so that
a separate tool can visualize it.

R=dsinclair@chromium.org, thestig@chromium.org
==========

to

==========
enable skia gradients, fix bugs

Allow shading to use Skia for some gradients;
linear, radial, and coons patch.

The corpus uncovered a few gradient-related bugs
in the Skia driver which are fixed as well.

Fix corpus 11.pdf by ignoring zero area
filled paths. PDFium uses CFX_PathData::GetZeroAreaPath()
to determine if a path that doesn't enclosing anything
should be drawn anyway, and CFX_AggDeviceDriver::GetDriverType()
returns 1 so that the empty path is tweaked so that
it doesn't draw too often.

There are no tests in the corpus that show
the utility of this approach; 11.pdf draws correctly
if the zero area paths are ignored.

Standardize debugging output so that
a separate tool can visualize it.

R=dsinclair@chromium.org, thestig@chromium.org
==========

[caryclark, 2016-11-30 18:36:32]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 18:36:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caryclark, 2016-11-30 18:39:27]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 18:39:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 18:57:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 18:57:27]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-12-05 14:22:43]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-12-05 14:22:44]

lgtm

[commit-bot: I haz the power, 2016-12-05 14:22:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 14:47:15]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1480947763719120,
"parent_rev": "4bed2af0c049bf499dcdb1327a47d40b4c0db92d", "commit_rev":
"d65fd10e080751e42b9ea2696ae3f4e54839461c"}

[commit-bot: I haz the power, 2016-12-05 14:47:18]

Description was changed from

==========
enable skia gradients, fix bugs

Allow shading to use Skia for some gradients;
linear, radial, and coons patch.

The corpus uncovered a few gradient-related bugs
in the Skia driver which are fixed as well.

Fix corpus 11.pdf by ignoring zero area
filled paths. PDFium uses CFX_PathData::GetZeroAreaPath()
to determine if a path that doesn't enclosing anything
should be drawn anyway, and CFX_AggDeviceDriver::GetDriverType()
returns 1 so that the empty path is tweaked so that
it doesn't draw too often.

There are no tests in the corpus that show
the utility of this approach; 11.pdf draws correctly
if the zero area paths are ignored.

Standardize debugging output so that
a separate tool can visualize it.

R=dsinclair@chromium.org, thestig@chromium.org
==========

to

==========
enable skia gradients, fix bugs

Allow shading to use Skia for some gradients;
linear, radial, and coons patch.

The corpus uncovered a few gradient-related bugs
in the Skia driver which are fixed as well.

Fix corpus 11.pdf by ignoring zero area
filled paths. PDFium uses CFX_PathData::GetZeroAreaPath()
to determine if a path that doesn't enclosing anything
should be drawn anyway, and CFX_AggDeviceDriver::GetDriverType()
returns 1 so that the empty path is tweaked so that
it doesn't draw too often.

There are no tests in the corpus that show
the utility of this approach; 11.pdf draws correctly
if the zero area paths are ignored.

Standardize debugging output so that
a separate tool can visualize it.

R=dsinclair@chromium.org, thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/d65fd10e080751e42b9ea2696ae3f4e54839...
==========

[commit-bot: I haz the power, 2016-12-05 14:47:19]

Committed patchset #7 (id:120001) as
https://pdfium.googlesource.com/pdfium/+/d65fd10e080751e42b9ea2696ae3f4e54839...