Issue 2530343002: (CANCELED) Delay determineAccessibleRole() from AXNodeObject::init() to roleValue()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2530343002: (CANCELED) Delay determineAccessibleRole() from AXNodeObject::init() to roleValue() (Closed)

Created:
4 years ago by kojii

Modified:
4 years ago

Reviewers:

CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, chromium-reviews, dmazzoni+watch_chromium.org, dmazzoni, dtseng+watch_chromium.org, haraken, je_julie, nektar+watch_chromium.org, nektarios, yuzo+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Delay determineAccessibleRole() from AXNodeObject::init() to roleValue() BUG=590369, 647602, 665168

Patch Set 1 #

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -4 lines)			Patch
M	third_party/WebKit/Source/modules/accessibility/AXNodeObject.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp	View	4 chunks	+15 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/modules/accessibility/AXObject.h	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530343002/1

4 years ago (2016-11-28 06:31:11 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years ago (2016-11-28 07:20:14 UTC) #3

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/188024)

4 years ago (2016-11-28 07:20:15 UTC) #4

kojii

4 years ago (2016-11-28 13:03:42 UTC) #5

Description was changed from

==========
WIP: ax-role

BUG=
==========

to

==========
Delay determineAccessibleRole() from AXNodeObject::init() to roleValue()

BUG=590369, 647602, 665168
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages