Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1151)

Unified Diff: third_party/WebKit/Source/platform/SharedBufferTest.cpp

Issue 2530323002: Replace boolean return value SharedBuffer::getAsBytes with DCHECK (Closed)
Patch Set: done Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/SharedBuffer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/SharedBufferTest.cpp
diff --git a/third_party/WebKit/Source/platform/SharedBufferTest.cpp b/third_party/WebKit/Source/platform/SharedBufferTest.cpp
index 5fd2f567c0cc35672fc78455090c4d1a46281f2c..823e4ef13ea02c3751e60287f2f0dae770a16109 100644
--- a/third_party/WebKit/Source/platform/SharedBufferTest.cpp
+++ b/third_party/WebKit/Source/platform/SharedBufferTest.cpp
@@ -52,7 +52,7 @@ TEST(SharedBufferTest, getAsBytes) {
const size_t size = sharedBuffer->size();
std::unique_ptr<char[]> data = wrapArrayUnique(new char[size]);
- ASSERT_TRUE(sharedBuffer->getAsBytes(data.get(), size));
+ sharedBuffer->getAsBytes(data.get(), size);
char expectedConcatenation[] = "HelloWorldGoodbye";
ASSERT_EQ(strlen(expectedConcatenation), size);
@@ -102,7 +102,7 @@ TEST(SharedBufferTest, getAsBytesLargeSegments) {
const size_t size = sharedBuffer->size();
std::unique_ptr<char[]> data = wrapArrayUnique(new char[size]);
- ASSERT_TRUE(sharedBuffer->getAsBytes(data.get(), size));
+ sharedBuffer->getAsBytes(data.get(), size);
ASSERT_EQ(0x4000U + 0x4000U + 0x4000U, size);
int position = 0;
« no previous file with comments | « third_party/WebKit/Source/platform/SharedBuffer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698