Replace boolean return value SharedBuffer::getAsBytes with DCHECK

third_party/WebKit/Source/platform/SharedBuffer.h

 /*
  * Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.
  * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 95 matching lines @@
   //      }
   HAS_STRICTLY_TYPED_ARG
   size_t getSomeData(
       const char*& data,
       STRICTLY_TYPED_ARG(position) = static_cast<size_t>(0)) const {
     STRICT_ARG_TYPE(size_t);
     return getSomeDataInternal(data, position);
   }
 
   // Returns the content data into "dest" as a flat buffer. "byteLength" must
-  // exactly match with size(). Returns true on success, otherwise the content
-  // of "dest" is not guaranteed.
+  // exactly match with size(). |dest| must not be null even if |bytesLength|
+  // is 0.
   HAS_STRICTLY_TYPED_ARG
-  bool getAsBytes(void* dest, STRICTLY_TYPED_ARG(byteLength)) const {
+  void getAsBytes(void* dest, STRICTLY_TYPED_ARG(byteLength)) const {
     STRICT_ARG_TYPE(size_t);
-    if (byteLength != size())
-      return false;
-
-    return getAsBytesInternal(dest, 0, byteLength);
+    DCHECK_EQ(byteLength, size());
+    auto result = getAsBytesInternal(dest, 0, byteLength);
+    DCHECK(result);
   }
 
   // Copies "byteLength" bytes from "position"-th bytes (0 origin) of the
   // content data into "dest" as a flat buffer, Returns true on success,
   // otherwise the content of "dest" is not guaranteed.
   HAS_STRICTLY_TYPED_ARG
   bool getPartAsBytes(void* dest,
                       STRICTLY_TYPED_ARG(position),
                       STRICTLY_TYPED_ARG(byteLength)) const {
     STRICT_ARG_TYPE(size_t);
@@ skipping 20 matching lines @@
   size_t getSomeDataInternal(const char*& data, size_t position) const;
 
   size_t m_size;
   mutable Vector<char> m_buffer;
   mutable Vector<char*> m_segments;
 };
 
 }  // namespace blink
 
 #endif  // SharedBuffer_h