Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2530263002: Turn on Analytic AA in Chrome (take 5) (Closed)

Created:
4 years ago by f(malita)
Modified:
4 years ago
Reviewers:
ajuma, f(malita), liyuqian
CC:
chromium-reviews, blink-reviews, cc-bugs_chromium.org, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn on Analytic AA in Chrome (take 5) Migrated from http://crrev.com/2513303002. Original author: liyuqian@chromium.org Update cc_unittests png files to reflect our changes. We also downgraded some ref tests to pixel tests because there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the circle boundaries. This seems to be reasonable as the test html usually has more layers than the ref html. In the future, we may set a configurable threshold for ref tests so we don't have to downgrade ref tests for this reason. R=fmalita@chromium.org,liyuqian@chromium.org TBR=ajuma@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://chromium.googlesource.com/chromium/src/+/f46247289db27ff645f76261186189a96115dde8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -222 lines) Patch
M cc/test/data/background_filter_on_scaled_layer_sw.png View Binary file 0 comments Download
M cc/test/data/background_filter_rotated_sw.png View Binary file 0 comments Download
M cc/test/data/rotated_drop_shadow_filter_sw.png View Binary file 0 comments Download
M cc/test/data/rotated_filter_sw.png View Binary file 0 comments Download
M cc/test/data/scaled_render_surface_layer_sw.png View Binary file 0 comments Download
M skia/config/SkUserConfig.h View 2 chunks +4 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/masking/clip-path-restore-expected.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/css3/masking/mask-luminance-svg-expected.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/box-shadow/box-shadow-with-zero-radius-expected.html View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/layers/overflow-hidden-rounded-corners-occlusion-expected.html View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/images/cross-fade-svg-size-diff-expected.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/images/cross-fade-svg-size-expected.html View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/clipath/clip-path-with-background-and-box-behind-expected.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/scrollbars/auto-scrollbar-fades-out-expected.html View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/canvas/canvas-default-object-sizing-expected.html View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f46247289db27ff645f76261186189a96115dde8 Cr-Commit-Position: refs/heads/master@{#434575}
4 years ago (2016-11-26 17:27:52 UTC) #6
f(malita)
Committed patchset #1 (id:1) manually as f46247289db27ff645f76261186189a96115dde8 (presubmit successful).
4 years ago (2016-11-26 17:28:59 UTC) #8
f(malita)
4 years ago (2016-11-26 17:32:21 UTC) #9
Message was sent while issue was closed.
On 2016/11/26 17:28:59, f(malita) wrote:
> Committed patchset #1 (id:1) manually as
> f46247289db27ff645f76261186189a96115dde8 (presubmit successful).

Committed manually, with a massive rebaseline:

  6400 files changed, 374 insertions(+), 247 deletions(-)

Note for sheriffs:

I'll check on the bots later and try to clean up any fallout.  With so
many updated baselines, some stuff is bound to have fallen through the cracks;
if
you notice minor anti-aliasing pixel diffs, feel free to rebaseline (or suppress
and assign to myself or Yuqian).

Also, if you must revert, you'll have to revert the actual revision manually
(reverting this uploaded CL won't help).

Powered by Google App Engine
This is Rietveld 408576698