Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: pkg/kernel/lib/ast.dart

Issue 2530203003: Document that setter expressions return their right-hand side. (Closed)
Patch Set: Change "returns" to "evaluates to" Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/ast.dart
diff --git a/pkg/kernel/lib/ast.dart b/pkg/kernel/lib/ast.dart
index 40a305ffae302b36811a9f499b808849372595a7..f4600f80ec77ee5b59137814259a7cb394e58a5e 100644
--- a/pkg/kernel/lib/ast.dart
+++ b/pkg/kernel/lib/ast.dart
@@ -1306,6 +1306,8 @@ class VariableGet extends Expression {
}
/// Assign a local variable or function parameter.
+///
+/// Evaluates to the value of [value].
class VariableSet extends Expression {
VariableDeclaration variable;
Expression value;
@@ -1387,6 +1389,8 @@ class PropertyGet extends Expression {
/// Expression of form `x.field = value`.
///
/// This may invoke a setter or assign a field.
+///
+/// Evaluates to the value of [value].
class PropertySet extends Expression {
Expression receiver;
Name name;
@@ -1461,6 +1465,8 @@ class DirectPropertyGet extends Expression {
}
/// Directly assign a field, or call a setter.
+///
+/// Evaluates to the value of [value].
class DirectPropertySet extends Expression {
Expression receiver;
Member target;
@@ -1580,6 +1586,8 @@ class SuperPropertyGet extends Expression {
/// Expression of form `super.field = value`.
///
/// This may invoke a setter or assign a field.
+///
+/// Evaluates to the value of [value].
class SuperPropertySet extends Expression {
Name name;
Expression value;
@@ -1632,6 +1640,8 @@ class StaticGet extends Expression {
}
/// Assign a static field or call a static setter.
+///
+/// Evaluates to the value of [value].
class StaticSet extends Expression {
/// A mutable static field or a static setter.
Member target;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698