Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 2530203003: Document that setter expressions return their right-hand side. (Closed)

Created:
4 years ago by asgerf
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Document that setter expressions return their right-hand side. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/0ae961f4286a0d5f4c19d64af90bf4e0487d5385

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change "returns" to "evaluates to" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M pkg/kernel/lib/ast.dart View 1 5 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
asgerf
4 years ago (2016-11-25 16:17:06 UTC) #2
Kevin Millikin (Google)
I have a comment, but it LGTM though. https://codereview.chromium.org/2530203003/diff/1/pkg/kernel/lib/ast.dart File pkg/kernel/lib/ast.dart (right): https://codereview.chromium.org/2530203003/diff/1/pkg/kernel/lib/ast.dart#newcode1310 pkg/kernel/lib/ast.dart:1310: /// ...
4 years ago (2016-11-28 11:12:20 UTC) #3
asgerf
https://codereview.chromium.org/2530203003/diff/1/pkg/kernel/lib/ast.dart File pkg/kernel/lib/ast.dart (right): https://codereview.chromium.org/2530203003/diff/1/pkg/kernel/lib/ast.dart#newcode1310 pkg/kernel/lib/ast.dart:1310: /// Returns the value of [value]. On 2016/11/28 11:12:20, ...
4 years ago (2016-11-28 11:26:54 UTC) #4
asgerf
4 years ago (2016-11-28 11:27:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0ae961f4286a0d5f4c19d64af90bf4e0487d5385 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698