Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2530193002: Fix crash in WizardController for Active Directory devices (Closed)

Created:
4 years ago by Roman Sorokin (ftl)
Modified:
4 years ago
Reviewers:
Thiemo Nagel, achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash in WizardController for Active Directory devices BUG=656992 TEST=manual Committed: https://crrev.com/42839ee8c1195b25fbe327057e10c54f592b6693 Cr-Commit-Position: refs/heads/master@{#434626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Roman Sorokin (ftl)
Achuith, PTAL
4 years ago (2016-11-25 15:02:26 UTC) #4
Roman Sorokin (ftl)
4 years ago (2016-11-25 15:03:11 UTC) #5
achuithb
lgtm
4 years ago (2016-11-28 08:51:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530193002/1
4 years ago (2016-11-28 09:37:11 UTC) #10
Thiemo Nagel
On 2016/11/28 09:37:11, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years ago (2016-11-28 09:46:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 10:05:22 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-28 10:07:57 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42839ee8c1195b25fbe327057e10c54f592b6693
Cr-Commit-Position: refs/heads/master@{#434626}

Powered by Google App Engine
This is Rietveld 408576698