Make the name of the event source for SYSLOG configurable.

base/syslog_logging.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/debug/stack_trace.h"
 #include "base/syslog_logging.h"
 
 #if defined(OS_WIN)
 #include "base/win/eventlog_messages.h"
 
 #include <windows.h>
 #elif defined(OS_LINUX)
 #include <syslog.h>
 #endif
 
 #include <cstring>
 #include <ostream>
 #include <string>
 
 namespace logging {
 
+#if defined(OS_WIN)
+
+namespace {
+std::string* g_event_source_name = nullptr;
+}
+
+void SetEventSourceName(const std::string& name) {
+  DCHECK(g_event_source_name == nullptr);

[grt (UTC plus 2), 2016/11/28 12:49:52]

nit: DCHECK_EQ(g_event_source_name, nullptr);

[pastarmovj, 2016/11/28 15:53:17]

Done.

+  g_event_source_name = new std::string(name);
+}
+#endif  // defined(OS_WIN)
+
 EventLogMessage::EventLogMessage(const char* file,
                                  int line,
                                  LogSeverity severity)
     : log_message_(file, line, severity) {
 }
 
 EventLogMessage::~EventLogMessage() {
 #if defined(OS_WIN)
-  const char kEventSource[] = "chrome";
-  HANDLE event_log_handle = RegisterEventSourceA(NULL, kEventSource);
+  // If g_event_source_name is nullptr (which it is per default) SYSLOG will
+  // degrade gracefully to regular LOG with an extra error suffix. If you see
+  // this happening most probably you are using SYSLOG before you called
+  // SetEventSourceName.
+  if (g_event_source_name == nullptr) {
+    stream() << " !!EVENTLOG SOURCE NAME NOT SET!!";
+    return;
+  }
+  HANDLE event_log_handle =
+      RegisterEventSourceA(NULL, g_event_source_name->c_str());
   if (event_log_handle == NULL) {
     stream() << " !!NOT ADDED TO EVENTLOG!!";
     return;
   }
 

[grt (UTC plus 2), 2016/11/28 12:49:52]

nit: consider
  base::ScopedClosureRunner
auto_deregister(base::Bind(base::IgnoreResult(&DeregisterEventSource),
event_log_handle));
(or something like that)
and remove line 80 to avoid a possible future handle leak when someone adds a
return statement in the middle of this.

[pastarmovj, 2016/11/28 15:53:17]

Done.

   std::string message(log_message_.str());
   WORD log_type = EVENTLOG_ERROR_TYPE;
   switch (log_message_.severity()) {
     case LOG_INFO:
       log_type = EVENTLOG_INFORMATION_TYPE;
       break;
     case LOG_WARNING:
       log_type = EVENTLOG_WARNING_TYPE;
       break;
     case LOG_ERROR:
@@ skipping 32 matching lines @@
     case LOG_FATAL:
       priority = 2;
       break;
   }
   syslog(priority, "%s", log_message_.str().c_str());
   closelog();
 #endif  // defined(OS_WIN)
 }
 
 }  // namespace logging