Make the name of the event source for SYSLOG configurable.

chrome/common/logging_chrome.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 // Need to include this before most other files because it defines
 // IPC_MESSAGE_LOG_ENABLED. We need to use it to define
 // IPC_MESSAGE_MACROS_LOG_ENABLED so render_messages.h will generate the
 // ViewMsgLog et al. functions.
@@ skipping 43 matching lines @@
 #include "content/public/common/content_switches.h"
 #include "ipc/ipc_logging.h"
 
 #if defined(OS_CHROMEOS)
 #include "chromeos/chromeos_switches.h"
 #endif
 
 #if defined(OS_WIN)
 #include <initguid.h>
 #include "base/logging_win.h"
+#include "base/syslog_logging.h"
+#include "chrome/install_static/install_modes.h"
 #endif
 
 namespace {
 
 // When true, this means that error dialogs should not be shown.
 bool dialogs_are_suppressed_ = false;
 
 // This should be true for exactly the period between the end of
 // InitChromeLogging() and the beginning of CleanupChromeLogging().
 bool chrome_logging_initialized_ = false;
@@ skipping 278 matching lines @@
         level < LOG_NUM_SEVERITIES) {
       logging::SetMinLogLevel(level);
     } else {
       DLOG(WARNING) << "Bad log level: " << log_level;
     }
   }
 
 #if defined(OS_WIN)
   // Enable trace control and transport through event tracing for Windows.
   logging::LogEventProvider::Initialize(kChromeTraceProviderName);
+
+  // Enable logging to the Windows Event Log.
+  logging::SetEventSourceName(
+      base::UTF16ToASCII(install_static::kProductPathName));

[grt (UTC plus 2), 2016/11/25 15:25:35]

while this will be a brand-specific string (e.g., "Chromium" or "Chrome"), what
we need here is a "mode"-specific string to account for a product being
installed in multiple side-by-side locations (e.g., "Chrome SxS" or "Chrome
Beta" vs "Chrome"). i propose that you add a new member to
install_static::InstallConstants for the log event source name and add values
for it to the kInstallModes definitions in chromium_install_modes.cc and
google_chrome_install_modes.cc. you can then add a convenience getter to
InstallDetails that you call here.

[pastarmovj, 2016/11/28 12:23:03]

I am not convinced that this particular use case deserves splitting up at such
fine granularity. But the code needed to achieve it is not much and we can
rather do this now than later.

I decided to go for a more generic install_full_name() rather than a specific to
this case name. WDYT?

 #endif
 
   base::StatisticsRecorder::InitLogOnShutdown();
 
   chrome_logging_initialized_ = true;
 }
 
 // This is a no-op, but we'll keep it around in case
 // we need to do more cleanup in the future.
 void CleanupChromeLogging() {
@@ skipping 38 matching lines @@
                                           time_deets.year,
                                           time_deets.month,
                                           time_deets.day_of_month,
                                           time_deets.hour,
                                           time_deets.minute,
                                           time_deets.second);
   return base_path.InsertBeforeExtensionASCII(suffix);
 }
 
 }  // namespace logging