Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2530143002: MIPS: Fix trampoline emission after switch table generation (Closed)

Created:
4 years ago by dusan.simicic
Modified:
4 years ago
Reviewers:
ivica.bogosavljevic, v8-mips-ports, miran.karic, Marija Antic
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix trampoline emission after switch table generation Trampolines are generated when the value of pc_offset is greater than next_buffer_check_ (attribute from Assembler class). This value shouldn't be incremented in bind_to() method when internal reference label is bound, because it is not decremented when the switch table is generated (dd() method from Assemler class). This patch fixes this problem. Regression test are also included for mips and mips64 arch. BUG= Committed: https://crrev.com/d735f3ab12061f0a588b3f0538f9229cf747f818 Cr-Commit-Position: refs/heads/master@{#41423}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -12 lines) Patch
M src/mips/assembler-mips.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M src/mips64/assembler-mips64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M test/cctest/test-macro-assembler-mips.cc View 1 chunk +84 lines, -0 lines 0 comments Download
M test/cctest/test-macro-assembler-mips64.cc View 1 chunk +84 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
dusan.simicic
PTAL
4 years ago (2016-11-25 13:48:33 UTC) #2
Marija Antic
On 2016/11/25 13:48:33, dusan.simicic wrote: > PTAL lgtm
4 years ago (2016-12-01 10:53:29 UTC) #3
ivica.bogosavljevic
lgtm
4 years ago (2016-12-01 11:53:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530143002/1
4 years ago (2016-12-01 13:01:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 13:03:05 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-01 13:03:25 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d735f3ab12061f0a588b3f0538f9229cf747f818
Cr-Commit-Position: refs/heads/master@{#41423}

Powered by Google App Engine
This is Rietveld 408576698