Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 253013004: git new-branch displays an explanatory line. (Closed)

Created:
6 years, 7 months ago by pgervais
Modified:
6 years, 7 months ago
Reviewers:
iannucci, szager1
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

git new-branch displays an explanatory line. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=266905

Patch Set 1 #

Total comments: 2

Patch Set 2 : Print message to stderr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M git_new_branch.py View 1 1 chunk +1 line, -1 line 0 comments Download
M subprocess2.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
pgervais
Small fix
6 years, 7 months ago (2014-04-28 21:40:12 UTC) #1
szager1
lgtm with nit https://codereview.chromium.org/253013004/diff/1/git_new_branch.py File git_new_branch.py (right): https://codereview.chromium.org/253013004/diff/1/git_new_branch.py#newcode49 git_new_branch.py:49: print('Switched to branch %s.' % opts.branch_name) ...
6 years, 7 months ago (2014-04-28 21:44:40 UTC) #2
iannucci
lgtm same comment https://codereview.chromium.org/253013004/diff/1/git_new_branch.py File git_new_branch.py (right): https://codereview.chromium.org/253013004/diff/1/git_new_branch.py#newcode49 git_new_branch.py:49: print('Switched to branch %s.' % opts.branch_name) ...
6 years, 7 months ago (2014-04-28 22:01:37 UTC) #3
pgervais
Message is now printed to stderr. Thanks for pointing that out.
6 years, 7 months ago (2014-04-28 22:14:47 UTC) #4
pgervais
The CQ bit was checked by pgervais@chromium.org
6 years, 7 months ago (2014-04-29 17:05:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pgervais@chromium.org/253013004/20001
6 years, 7 months ago (2014-04-29 17:06:22 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 17:08:13 UTC) #7
Message was sent while issue was closed. 
Change committed as 266905

Powered by Google App Engine
This is Rietveld 408576698