Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2530093002: [debug] do not retroactively apply script break points. (Closed)

Created:
4 years ago by Yang
Modified:
4 years ago
Reviewers:
kozy, jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] do not retroactively apply script break points. R=jgruber@chromium.org, kozyatinskiy@chromium.org BUG=v8:5510 Committed: https://crrev.com/0d4219913eff4f6a81514e8cff4195e16877f48d Cr-Commit-Position: refs/heads/master@{#41549}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -311 lines) Patch
M src/debug/debug.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M src/debug/debug.js View 3 chunks +0 lines, -45 lines 0 comments Download
M src/debug/liveedit.js View 4 chunks +0 lines, -84 lines 0 comments Download
M test/cctest/test-debug.cc View 1 2 11 chunks +36 lines, -172 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Yang
4 years ago (2016-11-25 10:46:05 UTC) #1
jgruber
lgtm
4 years ago (2016-11-25 10:55:30 UTC) #2
Yang
On 2016/11/25 10:55:30, jgruber wrote: > lgtm ping. Alexey, did you have time to apply ...
4 years ago (2016-12-01 12:38:37 UTC) #7
Yang
On 2016/12/01 12:38:37, Yang wrote: > On 2016/11/25 10:55:30, jgruber wrote: > > lgtm > ...
4 years ago (2016-12-05 18:41:01 UTC) #8
kozy
lgtm, fix on DevTools side was landed: https://codereview.chromium.org/2552923002/
4 years ago (2016-12-06 18:36:57 UTC) #9
Yang
On 2016/12/06 18:36:57, kozyatinskiy wrote: > lgtm, fix on DevTools side was landed: > https://codereview.chromium.org/2552923002/ ...
4 years ago (2016-12-07 11:18:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530093002/40001
4 years ago (2016-12-07 11:18:59 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-07 11:44:10 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-07 11:44:20 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0d4219913eff4f6a81514e8cff4195e16877f48d
Cr-Commit-Position: refs/heads/master@{#41549}

Powered by Google App Engine
This is Rietveld 408576698