[LayoutNG] Remove all mentions of NGBox and NGInlineBox.

[LayoutNG] Remove all mentions of NGBox and NGInlineBox.

It's called NGBlockNode and NGInlineNode now.

Also removed an old TODO about common base class for NGBlockNode and
NGInlineNode. They do have a common base class now.

Committed: https://crrev.com/90d863bca3aaa93e4ac12a3e8edc65499b11f4ce
Cr-Commit-Position: refs/heads/master@{#434630}

[mstensho (USE GERRIT), 2016-11-25 14:16:21]

mstensho@opera.com changed reviewers:
+ eae@chromium.org

[eae, 2016-11-25 16:37:51]

LGTM, thank you!

[eae, 2016-11-25 16:37:56]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-11-25 16:38:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-25 18:19:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-25 18:19:55]

Failed to apply patch for
third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc:39
  error: third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc: patch
does not apply

Patch:       third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc
Index: third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc
b/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc
index
52d49b8fa0e37da674e7046daca27f4a7034e3d2..48d3578783577c8d701e179a34fb94602132f51e
100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc
@@ -39,15 +39,15 @@ class NGInlineNodeForTest : public NGInlineNode {
   void SegmentText() { NGInlineNode::SegmentText(); }
 };
 
-class NGInlineBoxTest : public ::testing::Test {};
+class NGInlineNodeTest : public ::testing::Test {};
 
-TEST_F(NGInlineBoxTest, SegmentEmpty) {
+TEST_F(NGInlineNodeTest, SegmentEmpty) {
   RefPtr<ComputedStyle> style = ComputedStyle::create();
   NGInlineNodeForTest* box = new NGInlineNodeForTest(style.get());
   box->SegmentText();
 }
 
-TEST_F(NGInlineBoxTest, SegmentASCII) {
+TEST_F(NGInlineNodeTest, SegmentASCII) {
   RefPtr<ComputedStyle> style = ComputedStyle::create();
   NGInlineNodeForTest* box = new NGInlineNodeForTest(style.get());
   box->AppendText("Hello");
@@ -59,7 +59,7 @@ TEST_F(NGInlineBoxTest, SegmentASCII) {
   EXPECT_EQ(LTR, item.Direction());
 }
 
-TEST_F(NGInlineBoxTest, SegmentHebrew) {
+TEST_F(NGInlineNodeTest, SegmentHebrew) {
   RefPtr<ComputedStyle> style = ComputedStyle::create();
   NGInlineNodeForTest* box = new NGInlineNodeForTest(style.get());
   box->AppendText(u"\u05E2\u05D1\u05E8\u05D9\u05EA");
@@ -71,7 +71,7 @@ TEST_F(NGInlineBoxTest, SegmentHebrew) {
   EXPECT_EQ(RTL, item.Direction());
 }
 
-TEST_F(NGInlineBoxTest, SegmentSplit1To2) {
+TEST_F(NGInlineNodeTest, SegmentSplit1To2) {
   RefPtr<ComputedStyle> style = ComputedStyle::create();
   NGInlineNodeForTest* box = new NGInlineNodeForTest(style.get());
   box->AppendText(u"Hello \u05E2\u05D1\u05E8\u05D9\u05EA");
@@ -87,7 +87,7 @@ TEST_F(NGInlineBoxTest, SegmentSplit1To2) {
   EXPECT_EQ(RTL, item.Direction());
 }
 
-TEST_F(NGInlineBoxTest, SegmentSplit3To4) {
+TEST_F(NGInlineNodeTest, SegmentSplit3To4) {
   RefPtr<ComputedStyle> style = ComputedStyle::create();
   NGInlineNodeForTest* box = new NGInlineNodeForTest(style.get());
   box->AppendText("Hel");

[mstensho (USE GERRIT), 2016-11-28 08:41:19]

The CQ bit was checked by mstensho@opera.com

[mstensho (USE GERRIT), 2016-11-28 08:41:20]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2530083003/#ps20001
(title: "rebase master")

[commit-bot: I haz the power, 2016-11-28 08:41:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 10:32:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480322479678330,
"parent_rev": "aa9b31dda8363b41d72dae63615bb0852fac5bf5", "commit_rev":
"3bd1136478d57a30515c07422c0e950e497de958"}

[commit-bot: I haz the power, 2016-11-28 10:33:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-28 10:35:50]

Description was changed from

==========
[LayoutNG] Remove all mentions of NGBox and NGInlineBox.

It's called NGBlockNode and NGInlineNode now.

Also removed an old TODO about common base class for NGBlockNode and
NGInlineNode. They do have a common base class now.
==========

to

==========
[LayoutNG] Remove all mentions of NGBox and NGInlineBox.

It's called NGBlockNode and NGInlineNode now.

Also removed an old TODO about common base class for NGBlockNode and
NGInlineNode. They do have a common base class now.

Committed: https://crrev.com/90d863bca3aaa93e4ac12a3e8edc65499b11f4ce
Cr-Commit-Position: refs/heads/master@{#434630}
==========

[commit-bot: I haz the power, 2016-11-28 10:35:50]

Patchset 2 (id:??) landed as
https://crrev.com/90d863bca3aaa93e4ac12a3e8edc65499b11f4ce
Cr-Commit-Position: refs/heads/master@{#434630}