Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2530083003: [LayoutNG] Remove all mentions of NGBox and NGInlineBox. (Closed)

Created:
4 years ago by mstensho (USE GERRIT)
Modified:
4 years ago
Reviewers:
eae
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Remove all mentions of NGBox and NGInlineBox. It's called NGBlockNode and NGInlineNode now. Also removed an old TODO about common base class for NGBlockNode and NGInlineNode. They do have a common base class now. Committed: https://crrev.com/90d863bca3aaa93e4ac12a3e8edc65499b11f4ce Cr-Commit-Position: refs/heads/master@{#434630}

Patch Set 1 #

Patch Set 2 : rebase master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_node.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.h View 1 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_input_node.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
mstensho (USE GERRIT)
4 years ago (2016-11-25 14:16:22 UTC) #2
eae
LGTM, thank you!
4 years ago (2016-11-25 16:37:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530083003/1
4 years ago (2016-11-25 16:38:10 UTC) #5
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/layout/ng/ng_inline_node_test.cc: While running git apply --index -p1; error: patch failed: ...
4 years ago (2016-11-25 18:19:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2530083003/20001
4 years ago (2016-11-28 08:41:37 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-28 10:33:05 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-28 10:35:50 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/90d863bca3aaa93e4ac12a3e8edc65499b11f4ce
Cr-Commit-Position: refs/heads/master@{#434630}

Powered by Google App Engine
This is Rietveld 408576698