Add kAccessibilityFocusFallsbackToWidget property

components/exo/shell_surface.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/exo/shell_surface.h"
 
 #include <algorithm>
 
 #include "ash/aura/wm_window_aura.h"
 #include "ash/common/shelf/wm_shelf.h"
@@ skipping 1002 matching lines @@
   // region is non-empty. See OnCommitSurface() for more details.
   if (container_ == ash::kShellWindowId_SystemModalContainer)
     activatable &= !surface_->GetHitTestBounds().IsEmpty();
   params.activatable = activatable ? views::Widget::InitParams::ACTIVATABLE_YES
                                    : views::Widget::InitParams::ACTIVATABLE_NO;
 
   // Note: NativeWidget owns this widget.
   widget_ = new ShellSurfaceWidget(this);
   widget_->Init(params);
 
+  views::View* root_view = widget_->GetRootView();
+  if (root_view != nullptr) {

[reveman, 2016/11/30 17:00:40]

nit: s/root_view != nullptr/root_view/

when is this null? DCHECK instead?

[yawano, 2016/12/01 00:24:23]

Done. I don't come up case where it becomes null. DCHECK will be enough.

+    root_view->SetFocusBehavior(views::View::FocusBehavior::NEVER);

[reveman, 2016/11/30 17:00:40]

Can you explain in the description of this change why we want this for all exo
shell surfaces? I'm failing to see what any of this has to do with BubbleWidgets
as mentioned in the description..

[yawano, 2016/12/01 00:24:23]

Added comment.

+  }
+
   aura::Window* window = widget_->GetNativeWindow();
   window->SetName("ExoShellSurface");
   window->AddChild(surface_->window());
   window->SetEventTargeter(base::WrapUnique(new CustomWindowTargeter(widget_)));
   SetApplicationId(window, application_id_);
   SetMainSurface(window, surface_);
 
   // Start tracking changes to window bounds and window state.
   window->AddObserver(this);
   ash::wm::WindowState* window_state = ash::wm::GetWindowState(window);
@@ skipping 369 matching lines @@
       shadow_overlay_->layer()->Add(shadow->layer());
       window->AddChild(shadow_overlay_);
       shadow_overlay_->Show();
     }
     shadow_overlay_->SetBounds(shadow_bounds);
     shadow->SetContentBounds(gfx::Rect(shadow_bounds.size()));
   }
 }
 
 }  // namespace exo