Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: components/metrics/call_stack_profile_metrics_provider.h

Issue 2530043002: Set process phases in the StackSamplingProfiler. (Closed)
Patch Set: improved comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | components/metrics/call_stack_profile_metrics_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/call_stack_profile_metrics_provider.h
diff --git a/components/metrics/call_stack_profile_metrics_provider.h b/components/metrics/call_stack_profile_metrics_provider.h
index 74b0967943fd97cf532fdab90348f8968bff13c0..5c4f0db7f94e39dd53dd15c84e35df876d8f2852 100644
--- a/components/metrics/call_stack_profile_metrics_provider.h
+++ b/components/metrics/call_stack_profile_metrics_provider.h
@@ -19,10 +19,10 @@ class ChromeUserMetricsExtension;
// Performs metrics logging for the stack sampling profiler.
class CallStackProfileMetricsProvider : public MetricsProvider {
public:
- // These phases of a process lifetime can be passed as process "phases" to
- // StackSmaplingProfile::SetProcessPhase(). Be sure to update the translation
- // constants at the top of the .cc file when this is changed.
- enum Phases : int {
+ // These milestones of a process lifetime can be passed as process "mile-
+ // stones" to StackSmaplingProfile::SetProcessMilestone(). Be sure to update
+ // the translation constants at the top of the .cc file when this is changed.
+ enum Milestones : int {
MAIN_LOOP_START,
MAIN_NAVIGATION_START,
MAIN_NAVIGATION_FINISHED,
@@ -30,7 +30,7 @@ class CallStackProfileMetricsProvider : public MetricsProvider {
SHUTDOWN_START,
- PHASES_MAX_VALUE
+ MILESTONES_MAX_VALUE
};
CallStackProfileMetricsProvider();
« no previous file with comments | « chrome/browser/chrome_browser_main.cc ('k') | components/metrics/call_stack_profile_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698