Set process phases in the StackSamplingProfiler.

components/startup_metric_utils/browser/startup_metric_utils.cc

Index: components/startup_metric_utils/browser/startup_metric_utils.cc
diff --git a/components/startup_metric_utils/browser/startup_metric_utils.cc b/components/startup_metric_utils/browser/startup_metric_utils.cc
index 6d0ec9a7123037b057720c49e3b25a249bbca3d1..30f355de1688aadd06d86ad2251eb057d5655d24 100644
--- a/components/startup_metric_utils/browser/startup_metric_utils.cc
+++ b/components/startup_metric_utils/browser/startup_metric_utils.cc
@@ -16,11 +16,13 @@
 #include "base/metrics/histogram.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/process/process_info.h"
+#include "base/profiler/stack_sampling_profiler.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/sys_info.h"
 #include "base/threading/platform_thread.h"
 #include "base/trace_event/trace_event.h"
 #include "build/build_config.h"
+#include "components/metrics/call_stack_profile_metrics_provider.h"
 #include "components/prefs/pref_registry_simple.h"
 #include "components/prefs/pref_service.h"
 #include "components/startup_metric_utils/browser/pref_names.h"
@@ -592,14 +594,8 @@ void RecordBrowserMainMessageLoopStart(const base::TimeTicks& ticks,
                                        PrefService* pref_service) {
   DCHECK(pref_service);
 
-  RecordSameVersionStartupCount(pref_service);

[fdoray, 2017/01/12 16:56:56]

RecordSameVersionStartupCount() and RecordHardFaultHistogram(); must be called
before Startup.BrowserMessageLoopStartTime is recorded because they set global
variables used by the
UMA_HISTOGRAM_AND_TRACE_WITH_TEMPERATURE_AND_SAME_VERSION_COUNT macro.

Could add this before RecordSameVersionStartupCount():

// Keep RecordSameVersionStartupCount() and RecordHardFaultHistogram() first
// as many other histograms depend on them setting 
// |g_startups_with_current_version| and |g_startup_temperature|.

[bcwhite, 2017/01/12 17:47:03]

Done.

-  // Keep RecordHardFaultHistogram() first as much as possible as many other
-  // histograms depend on it setting |g_startup_temperature|.
-  RecordHardFaultHistogram();
-  AddStartupEventsForTelemetry();
-  RecordTimeSinceLastStartup(pref_service);
-  RecordSystemUptimeHistogram();
-  RecordMainEntryTimeHistogram();
+  base::StackSamplingProfiler::SetProcessMilestone(
+      metrics::CallStackProfileMetricsProvider::MAIN_LOOP_START);
 
   const base::TimeTicks& process_creation_ticks =
       g_process_creation_ticks.Get();
@@ -623,6 +619,15 @@ void RecordBrowserMainMessageLoopStart(const base::TimeTicks& ticks,
         g_browser_main_entry_point_ticks.Get(), ticks);
   }
 
+  RecordSameVersionStartupCount(pref_service);
+  // Keep RecordHardFaultHistogram() first as much as possible as many other
+  // histograms depend on it setting |g_startup_temperature|.
+  RecordHardFaultHistogram();
+  AddStartupEventsForTelemetry();
+  RecordTimeSinceLastStartup(pref_service);
+  RecordSystemUptimeHistogram();
+  RecordMainEntryTimeHistogram();
+
   // Record timings between process creation, the main() in the executable being
   // reached and the main() in the shared library being reached.
   if (!process_creation_ticks.is_null() &&
@@ -705,6 +710,8 @@ void RecordFirstWebContentsNonEmptyPaint(const base::TimeTicks& ticks) {
   if (WasNonBrowserUIDisplayed() || g_process_creation_ticks.Get().is_null())
     return;
 
+  base::StackSamplingProfiler::SetProcessMilestone(
+      metrics::CallStackProfileMetricsProvider::FIRST_NONEMPTY_PAINT);
   UMA_HISTOGRAM_AND_TRACE_WITH_TEMPERATURE_AND_SAME_VERSION_COUNT(
       UMA_HISTOGRAM_LONG_TIMES_100, "Startup.FirstWebContents.NonEmptyPaint2",
       g_process_creation_ticks.Get(), ticks);
@@ -718,6 +725,8 @@ void RecordFirstWebContentsMainNavigationStart(const base::TimeTicks& ticks) {
   if (WasNonBrowserUIDisplayed() || g_process_creation_ticks.Get().is_null())
     return;
 
+  base::StackSamplingProfiler::SetProcessMilestone(
+      metrics::CallStackProfileMetricsProvider::MAIN_NAVIGATION_START);
   UMA_HISTOGRAM_AND_TRACE_WITH_TEMPERATURE_AND_SAME_VERSION_COUNT(
       UMA_HISTOGRAM_LONG_TIMES_100,
       "Startup.FirstWebContents.MainNavigationStart",
@@ -733,6 +742,8 @@ void RecordFirstWebContentsMainNavigationFinished(
   if (WasNonBrowserUIDisplayed() || g_process_creation_ticks.Get().is_null())
     return;
 
+  base::StackSamplingProfiler::SetProcessMilestone(
+      metrics::CallStackProfileMetricsProvider::MAIN_NAVIGATION_FINISHED);
   UMA_HISTOGRAM_AND_TRACE_WITH_TEMPERATURE_AND_SAME_VERSION_COUNT(
       UMA_HISTOGRAM_LONG_TIMES_100,
       "Startup.FirstWebContents.MainNavigationFinished",