Set process phases in the StackSamplingProfiler.

components/metrics/call_stack_profile_metrics_provider_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/metrics/call_stack_profile_metrics_provider.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <utility>
@@ skipping 23 matching lines @@
   uint64_t name_md5;
   uint64_t base_address;
 };
 
 struct ExpectedProtoEntry {
   int32_t module_index;
   uint64_t address;
 };
 
 struct ExpectedProtoSample {
-  uint32_t process_phases;  // Bit-field of expected phases.
+  uint32_t process_milestones;  // Bit-field of expected milestones.
   const ExpectedProtoEntry* entries;
   int entry_count;
   int64_t entry_repeats;
 };
 
 struct ExpectedProtoProfile {
   int32_t duration_ms;
   int32_t period_ms;
   const ExpectedProtoModule* modules;
   int module_count;
   const ExpectedProtoSample* samples;
   int sample_count;
 };
 
 class ProfilesFactory {
  public:
   ProfilesFactory(){};
   ~ProfilesFactory(){};
 
-  ProfilesFactory& AddPhase(int phase);
+  ProfilesFactory& AddMilestone(int milestone);
   ProfilesFactory& NewProfile(int duration_ms, int interval_ms);
   ProfilesFactory& NewSample();
   ProfilesFactory& AddFrame(size_t module, uintptr_t offset);
   ProfilesFactory& DefineModule(const char* name,
                                 const base::FilePath& path,
                                 uintptr_t base);
 
   Profiles Build();
 
  private:
   Profiles profiles_;
-  uint32_t process_phases_ = 0;
+  uint32_t process_milestones_ = 0;
 
   DISALLOW_COPY_AND_ASSIGN(ProfilesFactory);
 };
 
-ProfilesFactory& ProfilesFactory::AddPhase(int phase) {
-  process_phases_ |= 1 << phase;
+ProfilesFactory& ProfilesFactory::AddMilestone(int milestone) {
+  process_milestones_ |= 1 << milestone;
   return *this;
 }
 
 ProfilesFactory& ProfilesFactory::NewProfile(int duration_ms, int interval_ms) {
   profiles_.push_back(Profile());
   Profile* profile = &profiles_.back();
   profile->profile_duration = base::TimeDelta::FromMilliseconds(duration_ms);
   profile->sampling_period = base::TimeDelta::FromMilliseconds(interval_ms);
   return *this;
 }
 
 ProfilesFactory& ProfilesFactory::NewSample() {
   profiles_.back().samples.push_back(Sample());
-  profiles_.back().samples.back().process_phases = process_phases_;
+  profiles_.back().samples.back().process_milestones = process_milestones_;
   return *this;
 }
 
 ProfilesFactory& ProfilesFactory::AddFrame(size_t module, uintptr_t offset) {
   profiles_.back().samples.back().frames.push_back(Frame(offset, module));
   return *this;
 }
 
 ProfilesFactory& ProfilesFactory::DefineModule(const char* name,
                                                const base::FilePath& path,
@@ skipping 67 matching lines @@
     EXPECT_EQ(expected.modules[m].build_id, module_id.build_id());
     ASSERT_TRUE(module_id.has_name_md5_prefix());
     EXPECT_EQ(expected.modules[m].name_md5, module_id.name_md5_prefix());
   }
 
   ASSERT_EQ(expected.sample_count, stack.sample().size());
   for (int s = 0; s < expected.sample_count; ++s) {
     SCOPED_TRACE("sample " + base::IntToString(s));
     const CallStackProfile::Sample& proto_sample = stack.sample().Get(s);
 
-    uint32_t process_phases = 0;
+    uint32_t process_milestones = 0;
     for (int i = 0; i < proto_sample.process_phase().size(); ++i)
-      process_phases |= 1U << proto_sample.process_phase().Get(i);
-    EXPECT_EQ(expected.samples[s].process_phases, process_phases);
+      process_milestones |= 1U << proto_sample.process_phase().Get(i);
+    EXPECT_EQ(expected.samples[s].process_milestones, process_milestones);
 
     ASSERT_EQ(expected.samples[s].entry_count, proto_sample.entry().size());
     ASSERT_TRUE(proto_sample.has_count());
     EXPECT_EQ(expected.samples[s].entry_repeats, proto_sample.count());
     for (int e = 0; e < expected.samples[s].entry_count; ++e) {
       SCOPED_TRACE("entry " + base::SizeTToString(e));
       const CallStackProfile::Entry& entry = proto_sample.entry().Get(e);
       if (expected.samples[s].entries[e].module_index >= 0) {
         ASSERT_TRUE(entry.has_module_id_index());
         EXPECT_EQ(expected.samples[s].entries[e].module_index,
@@ skipping 174 matching lines @@
   base::FilePath module_path(L"c:\\some\\path\\to\\chrome.exe");
 #else
   uint64_t module_md5 = 0x554838A8451AC36CULL;
   base::FilePath module_path("/some/path/to/chrome");
 #endif
 
   Profiles profiles = ProfilesFactory()
       .NewProfile(100, 10)
       .DefineModule(module_name, module_path, module_base_address)
 
-      .AddPhase(0)
+      .AddMilestone(0)
       .NewSample()
       .AddFrame(0, module_base_address + 0x10)
       .NewSample()
       .AddFrame(0, module_base_address + 0x20)
       .NewSample()
       .AddFrame(0, module_base_address + 0x10)
       .NewSample()
       .AddFrame(0, module_base_address + 0x10)
 
-      .AddPhase(1)
+      .AddMilestone(1)
       .NewSample()
       .AddFrame(0, module_base_address + 0x10)
       .NewSample()
       .AddFrame(0, module_base_address + 0x20)
       .NewSample()
       .AddFrame(0, module_base_address + 0x10)
       .NewSample()
       .AddFrame(0, module_base_address + 0x10)
 
       .Build();
@@ skipping 54 matching lines @@
   base::FilePath module_path(L"c:\\some\\path\\to\\chrome.exe");
 #else
   uint64_t module_md5 = 0x554838A8451AC36CULL;
   base::FilePath module_path("/some/path/to/chrome");
 #endif
 
   Profiles profiles = ProfilesFactory()
       .NewProfile(100, 10)
       .DefineModule(module_name, module_path, module_base_address)
 
-      .AddPhase(0)
+      .AddMilestone(0)
       .NewSample()
       .AddFrame(0, module_base_address + 0x10)
       .NewSample()
       .AddFrame(0, module_base_address + 0x20)
       .NewSample()
       .AddFrame(0, module_base_address + 0x10)
       .NewSample()
       .AddFrame(0, module_base_address + 0x10)
 
-      .AddPhase(1)
+      .AddMilestone(1)
       .NewSample()
       .AddFrame(0, module_base_address + 0x10)
       .NewSample()
       .AddFrame(0, module_base_address + 0x20)
       .NewSample()
       .AddFrame(0, module_base_address + 0x10)
       .NewSample()
       .AddFrame(0, module_base_address + 0x10)
 
       .Build();
@@ skipping 249 matching lines @@
       .AddFrame(Frame::kUnknownModuleIndex, 0x1234)
       .Build();
   callback.Run(std::move(profiles));
   ChromeUserMetricsExtension uma_proto;
   provider.ProvideGeneralMetrics(&uma_proto);
 
   EXPECT_EQ(0, uma_proto.sampled_profile_size());
 }
 
 }  // namespace metrics