<video> use cache if --enable-byte-range-support is present

<video> use cache if --enable-byte-range-support is present

BUG=16013
TEST=Playing a video should still work with the flag in incognito mode or not.

Allow <video> to use cache if running with experimental byte range support.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27589

[Alpha Left Google, 2009-09-26 02:01:14]

yay! :)

[scherkus (not reviewing), 2009-09-29 22:07:39]

http://codereview.chromium.org/253001/diff/2001/2006
File webkit/glue/webkit_glue.h (right):

http://codereview.chromium.org/253001/diff/2001/2006#newcode127
Line 127: void EnableMediaCache();
following common naming rules:
EnabledMediaCache() -> SetMediaCacheEnabled(bool enabled)

also the naming seems a bit strange.. the flag is --byte-range-support but it
actually enabled media cache?

maybe the flag should be --enable-media-cache since you're not enable byte range
support for anything other than media

also add a TODO to remove this :)

[Alpha Left Google, 2009-09-29 23:08:50]

http://codereview.chromium.org/253001/diff/2001/2006
File webkit/glue/webkit_glue.h (right):

http://codereview.chromium.org/253001/diff/2001/2006#newcode127
Line 127: void EnableMediaCache();
On 2009/09/29 22:07:39, scherkus wrote:
> following common naming rules:
> EnabledMediaCache() -> SetMediaCacheEnabled(bool enabled)
> 
> also the naming seems a bit strange.. the flag is --byte-range-support but it
> actually enabled media cache?
> 
> maybe the flag should be --enable-media-cache since you're not enable byte
range
> support for anything other than media
> 
> also add a TODO to remove this :)
> 

The rationale behind this is that:
If byte range support is enabled in the cache, we use it. :)

I'll fix the rest.

[scherkus (not reviewing), 2009-09-30 02:47:10]

LGTM with nit

http://codereview.chromium.org/253001/diff/2007/4006
File webkit/glue/webkit_glue.h (right):

http://codereview.chromium.org/253001/diff/2007/4006#newcode128
Line 128: void SetMediaCacheEnabled();
+ bool enabled