Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 252993003: Add a magnifier lens to the image. (Closed)

Created:
6 years, 7 months ago by jcgregorio
Modified:
6 years, 7 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add a magnifier lens to the image. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14424

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -212 lines) Patch
M experimental/webtry/css/webtry.css View 1 1 chunk +13 lines, -0 lines 0 comments Download
D experimental/webtry/js/run.js View 1 chunk +0 lines, -203 lines 0 comments Download
A + experimental/webtry/js/webtry.js View 1 2 1 chunk +79 lines, -0 lines 0 comments Download
M experimental/webtry/templates/content.html View 1 chunk +1 line, -1 line 0 comments Download
M experimental/webtry/templates/iframe.html View 1 1 chunk +1 line, -1 line 0 comments Download
M experimental/webtry/templates/index.html View 1 1 chunk +1 line, -1 line 0 comments Download
M experimental/webtry/templates/workspace.html View 1 1 chunk +1 line, -1 line 0 comments Download
M experimental/webtry/webtry.go View 1 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jcgregorio
6 years, 7 months ago (2014-04-28 19:44:47 UTC) #1
mtklein
https://codereview.chromium.org/252993003/diff/20001/experimental/webtry/js/webtry.js File experimental/webtry/js/webtry.js (right): https://codereview.chromium.org/252993003/diff/20001/experimental/webtry/js/webtry.js#newcode56 experimental/webtry/js/webtry.js:56: canvas.width=256; Can we grab the w/h from currentImage? https://codereview.chromium.org/252993003/diff/20001/experimental/webtry/js/webtry.js#newcode68 ...
6 years, 7 months ago (2014-04-28 19:53:16 UTC) #2
jcgregorio
https://codereview.chromium.org/252993003/diff/20001/experimental/webtry/js/webtry.js File experimental/webtry/js/webtry.js (right): https://codereview.chromium.org/252993003/diff/20001/experimental/webtry/js/webtry.js#newcode56 experimental/webtry/js/webtry.js:56: canvas.width=256; On 2014/04/28 19:53:17, mtklein wrote: > Can we ...
6 years, 7 months ago (2014-04-28 20:45:25 UTC) #3
mtklein
lgtm
6 years, 7 months ago (2014-04-28 20:49:52 UTC) #4
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 7 months ago (2014-04-28 20:50:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/252993003/40001
6 years, 7 months ago (2014-04-28 20:50:35 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 21:03:44 UTC) #7
Message was sent while issue was closed.
Change committed as 14424

Powered by Google App Engine
This is Rietveld 408576698