Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 2529883002: [debug] remove JSON debug protocol related tests. (Closed)

Created:
4 years ago by Yang
Modified:
4 years ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] remove JSON debug protocol related tests. In most cases we can use the debug event listener as alternative. Multithreaded tests are obsolete. R=jgruber@chromium.org BUG=v8:5510 Committed: https://crrev.com/81a64aa5488602e4643f1ecc3beeddb8828a853c Cr-Commit-Position: refs/heads/master@{#41256}

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 3

Patch Set 3 : fix #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -1492 lines) Patch
M include/v8-debug.h View 2 chunks +29 lines, -25 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-debug.cc View 1 2 23 chunks +91 lines, -1464 lines 2 comments Download
A test/inspector/runtime/evaluate-empty-stack.js View 1 chunk +13 lines, -0 lines 0 comments Download
A test/inspector/runtime/evaluate-empty-stack-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Yang
4 years ago (2016-11-24 09:11:10 UTC) #1
jgruber
lgtm https://codereview.chromium.org/2529883002/diff/20001/include/v8-debug.h File include/v8-debug.h (right): https://codereview.chromium.org/2529883002/diff/20001/include/v8-debug.h#newcode173 include/v8-debug.h:173: V8_DEPRECATED("No longer supported", 👍 https://codereview.chromium.org/2529883002/diff/20001/test/inspector/runtime/evaluate-empty-stack-expected.txt File test/inspector/runtime/evaluate-empty-stack-expected.txt (right): ...
4 years ago (2016-11-24 09:53:08 UTC) #8
Yang
https://codereview.chromium.org/2529883002/diff/20001/test/inspector/runtime/evaluate-empty-stack-expected.txt File test/inspector/runtime/evaluate-empty-stack-expected.txt (right): https://codereview.chromium.org/2529883002/diff/20001/test/inspector/runtime/evaluate-empty-stack-expected.txt#newcode7 test/inspector/runtime/evaluate-empty-stack-expected.txt:7: value : snape kills dumbledore On 2016/11/24 09:53:08, jgruber ...
4 years ago (2016-11-24 09:56:17 UTC) #9
jgruber
lgtm
4 years ago (2016-11-24 10:36:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529883002/40001
4 years ago (2016-11-24 10:41:23 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-24 10:43:07 UTC) #16
commit-bot: I haz the power
4 years ago (2016-11-24 10:43:30 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/81a64aa5488602e4643f1ecc3beeddb8828a853c
Cr-Commit-Position: refs/heads/master@{#41256}

Powered by Google App Engine
This is Rietveld 408576698