Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2529873002: Revert of [cleanup] Refactor builtins-number.cc (Closed)

Created:
4 years ago by Michael Hablich
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [cleanup] Refactor builtins-number.cc (patchset #2 id:40001 of https://codereview.chromium.org/2517833005/ ) Reason for revert: Secondary dependency to revert https://codereview.chromium.org/2522393002/ Original issue's description: > [cleanup] Refactor builtins-number.cc > > Introducing a TF_BUILTIN macro that wraps CodeStubAssembler usage > into a convenient interface (using a subclass under the hood). > > Committed: https://crrev.com/cbf59c4c704e83a43b52c5ba6825df576fdaece8 > Cr-Commit-Position: refs/heads/master@{#41236} TBR=ishell@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/3005cbd6f98ac7a4df69e79b956c03c9518a65a7 Cr-Commit-Position: refs/heads/master@{#41252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1113 lines, -930 lines) Patch
M src/builtins/builtins-number.cc View 4 chunks +1113 lines, -905 lines 0 comments Download
M src/builtins/builtins-utils.h View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Hablich
Created Revert of [cleanup] Refactor builtins-number.cc
4 years ago (2016-11-24 08:57:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529873002/1
4 years ago (2016-11-24 08:57:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 08:57:33 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3005cbd6f98ac7a4df69e79b956c03c9518a65a7 Cr-Commit-Position: refs/heads/master@{#41252}
4 years ago (2016-11-24 08:57:46 UTC) #7
Jakob Kummerow
4 years ago (2016-11-28 11:42:51 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2529373002/ by jkummerow@chromium.org.

The reason for reverting is: relanding.

Powered by Google App Engine
This is Rietveld 408576698