Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2529863002: Revert of [cleanup] CodeStubAssembler: s/compiler::Node/Node/ (Closed)

Created:
4 years ago by Michael Hablich
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [cleanup] CodeStubAssembler: s/compiler::Node/Node/ (patchset #1 id:1 of https://codereview.chromium.org/2526803002/ ) Reason for revert: Needed to revert https://codereview.chromium.org/2522393002/ Original issue's description: > Reland of [cleanup] CodeStubAssembler: s/compiler::Node/Node/ > > Reducing visual clutter. > > No changes since previous attempt; this was only reverted because it blocked another revert. > Original review: https://codereview.chromium.org/2519093002/ > > TBR=ishell@chromium.org > > Committed: https://crrev.com/c28bee0fdd297d2ef4fc88b5fe289cc9dbd664f6 > Cr-Commit-Position: refs/heads/master@{#41235} TBR=ishell@chromium.org,jkummerow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a87d2529991abade25ed3f1d07d7bb46360a6010 Cr-Commit-Position: refs/heads/master@{#41249}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+695 lines, -520 lines) Patch
M src/code-stub-assembler.h View 13 chunks +588 lines, -443 lines 0 comments Download
M src/code-stub-assembler.cc View 34 chunks +107 lines, -77 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Michael Hablich
Created Revert of [cleanup] CodeStubAssembler: s/compiler::Node/Node/
4 years ago (2016-11-24 08:39:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529863002/1
4 years ago (2016-11-24 08:40:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-24 08:40:12 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a87d2529991abade25ed3f1d07d7bb46360a6010 Cr-Commit-Position: refs/heads/master@{#41249}
4 years ago (2016-11-24 08:40:35 UTC) #7
Jakob Kummerow
4 years ago (2016-11-28 10:08:37 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2532063002/ by jkummerow@chromium.org.

The reason for reverting is: relanding.

Powered by Google App Engine
This is Rietveld 408576698