Move suspend logic into OnMemoryStateChange()

Move suspend logic into OnMemoryStateChange()

Before this CL, OnMemoryStateChange() only handles "purge" part
of purge+suspend mechanism. Handle "suspend" part as well.

BUG=617492
Committed: https://crrev.com/f1501024d0f0aa8ee537dd276504b05f3bd0145b
Cr-Commit-Position: refs/heads/master@{#434831}

[bashi, 2016-11-24 07:42:51]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 07:43:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2016-11-24 07:45:21]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org, tasak@google.com

[bashi, 2016-11-24 07:45:22]

PTAL. I want to make sure this doesn't break something.

[bashi, 2016-11-24 07:46:54]

https://codereview.chromium.org/2529833002/diff/1/content/renderer/render_thr...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/2529833002/diff/1/content/renderer/render_thr...
content/renderer/render_thread_impl.cc:1775: }
ah, Maybe I should add else clause and PostDelayedTask() here?

[tasak, 2016-11-24 08:17:26]

lgtm

[bashi, 2016-11-24 08:18:50]

https://codereview.chromium.org/2529833002/diff/1/content/renderer/render_thr...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/2529833002/diff/1/content/renderer/render_thr...
content/renderer/render_thread_impl.cc:1775: }
On 2016/11/24 07:46:54, bashi1 wrote:
> ah, Maybe I should add else clause and PostDelayedTask() here?

Chatted offline. We shouldn't record metrics when OnMemoryStateChange() is
called by memory coordinator (otherwise, we mix metrics for different
experiments). Reverted UMA recording move.

[haraken, 2016-11-24 08:19:23]

LGTM

[bashi, 2016-11-24 08:19:56]

bashi@chromium.org changed reviewers:
+ avi@chromium.org

[bashi, 2016-11-24 08:19:57]

avi@: could you do OWNERS review?

[bashi, 2016-11-28 01:57:14]

avi@: Friendly ping :)

[Avi (use Gerrit), 2016-11-28 18:10:28]

LGTM

FYI, it was a US corporate holiday when you sent this, so that's why I wasn't
responsive.

[bashi, 2016-11-28 23:01:26]

On 2016/11/28 18:10:28, Avi wrote:
> LGTM
> 
> FYI, it was a US corporate holiday when you sent this, so that's why I wasn't
> responsive.

Yes, I knew that :) Thanks for review!

[bashi, 2016-11-28 23:01:33]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2016-11-28 23:03:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-29 02:09:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480374093391230,
"parent_rev": "d116a1920867410228022ba7ad09e5c49761b9df", "commit_rev":
"1420c138f158123e376a52d9e2f793be6316b95a"}

[commit-bot: I haz the power, 2016-11-29 02:10:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-29 02:20:31]

Description was changed from

==========
Move suspend logic into OnMemoryStateChange()

Before this CL, OnMemoryStateChange() only handles "purge" part
of purge+suspend mechanism. Handle "suspend" part as well.

BUG=617492
==========

to

==========
Move suspend logic into OnMemoryStateChange()

Before this CL, OnMemoryStateChange() only handles "purge" part
of purge+suspend mechanism. Handle "suspend" part as well.

BUG=617492

Committed: https://crrev.com/f1501024d0f0aa8ee537dd276504b05f3bd0145b
Cr-Commit-Position: refs/heads/master@{#434831}
==========

[commit-bot: I haz the power, 2016-11-29 02:20:32]

Patchset 2 (id:??) landed as
https://crrev.com/f1501024d0f0aa8ee537dd276504b05f3bd0145b
Cr-Commit-Position: refs/heads/master@{#434831}