Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2529793002: Remove language settings Learn More URL from desktop MD Settings (Closed)

Created:
4 years ago by michaelpg
Modified:
4 years ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove language settings Learn More URL from desktop MD Settings The help text for languages, "Order languages by your preference", is not actually explained in the "Learn more" link on Desktop. The help center only includes that content for Chrome OS, by design (https://support.google.com/chromebook/answer/1059490?hl=en). So remove the "Learn more" link entirely in Desktop because it's not useful or relevant to this hlist. BUG=none R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/1174a0f81caf19f0ccb53ff7608625dcbcdb8be1 Cr-Commit-Position: refs/heads/master@{#435878}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/resources/settings/languages_page/languages_page.html View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
michaelpg
Dan: When I noticed that the Learn More link for ordering languages (same one that's ...
4 years ago (2016-11-24 03:50:35 UTC) #2
Dan Beam
i responded on the internal bug lgtm for now i suppose as the steps are ...
4 years ago (2016-11-28 21:59:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529793002/20001
4 years ago (2016-12-02 03:37:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/327424)
4 years ago (2016-12-02 06:26:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529793002/20001
4 years ago (2016-12-02 07:04:12 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-02 07:52:44 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-02 07:54:33 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1174a0f81caf19f0ccb53ff7608625dcbcdb8be1
Cr-Commit-Position: refs/heads/master@{#435878}

Powered by Google App Engine
This is Rietveld 408576698