arc: Implement uninstall confirmation dialog for Arc app.

chrome/browser/ui/app_list/arc/arc_app_utils.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/arc/arc_app_utils.h"
 
 #include <memory>
 #include <string>
 
 #include "ash/shell.h"
 #include "base/bind.h"
 #include "base/synchronization/waitable_event.h"
+#include "chrome/browser/profiles/profile.h"

[msw, 2016/11/29 20:47:36]

optional nit: this probably isn't needed (forward decl should suffice)

[lgcheng, 2016/11/30 19:28:46]

It seems I need this header file. 
static ArcAppListPrefs* Get(content::BrowserContext* context);

I need profile.h so that compile knows Profile is subclass of
content::BrowserContext

[msw, 2016/11/30 23:26:57]

Acknowledged.

 #include "chrome/browser/ui/app_list/arc/arc_app_list_prefs.h"
 #include "chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h"
 #include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/session_manager_client.h"
 #include "components/arc/arc_bridge_service.h"
 #include "components/arc/common/intent_helper.mojom.h"
 #include "ui/aura/window.h"
 #include "ui/display/display.h"
 #include "ui/display/screen.h"
@@ skipping 309 matching lines @@
   VLOG(2) << "Uninstalling " << package_name;
 
   arc::mojom::AppInstance* app_instance =
       GetAppInstance(kUninstallPackageMinVersion, kUninstallPackageStr);
   if (!app_instance)
     return;
 
   app_instance->UninstallPackage(package_name);
 }
 
+void UninstallArcApp(const std::string& app_id, Profile* profile) {
+  ArcAppListPrefs* arc_prefs = ArcAppListPrefs::Get(profile);
+  DCHECK(arc_prefs);
+  std::unique_ptr<ArcAppListPrefs::AppInfo> app_info =
+      arc_prefs->GetApp(app_id);
+  if (!app_info) {
+    VLOG(2) << "Package being uninstalled does not exist: " << app_id << ".";
+    return;
+  }
+  if (app_info->shortcut) {
+    // for shortcut we just remove the shortcut instead of the package

[msw, 2016/11/29 20:47:36]

nit: trailing period; optionally move above conditional to nix curlies.

[lgcheng, 2016/11/30 19:28:46]

Done.

+    arc_prefs->RemoveApp(app_id);
+  } else {
+    UninstallPackage(app_info->package_name);
+  }
+}
+
 void RemoveCachedIcon(const std::string& icon_resource_id) {
   VLOG(2) << "Removing icon " << icon_resource_id;
 
   arc::mojom::AppInstance* app_instance =
       GetAppInstance(kRemoveIconMinVersion, kRemoveIconStr);
   if (!app_instance)
     return;
 
   app_instance->RemoveCachedIcon(icon_resource_id);
 }
@@ skipping 21 matching lines @@
   if (!app_instance)
     return false;
 
   app_instance->ShowPackageInfoOnPage(
       package_name, page,
       GetTargetRect(gfx::Size(kNexus7Width, kNexus7Height)));
   return true;
 }
 
 }  // namespace arc