arc: Implement uninstall confirmation dialog for Arc app.

chrome/browser/ui/views/arc_app_dialog_view.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/app_list/arc/arc_app_dialog.h"
+
+#include "base/bind.h"
+#include "base/macros.h"
+#include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/extensions/extension_util.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/app_list/app_list_controller_delegate.h"
+#include "chrome/browser/ui/app_list/arc/arc_app_icon_loader.h"
+#include "chrome/browser/ui/app_list/arc/arc_app_list_prefs.h"
+#include "chrome/browser/ui/app_list/arc/arc_app_utils.h"
+#include "chrome/browser/ui/native_window_tracker.h"
+#include "chrome/grit/generated_resources.h"
+#include "components/constrained_window/constrained_window_views.h"
+#include "components/strings/grit/components_strings.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/ui_base_types.h"
+#include "ui/views/controls/image_view.h"
+#include "ui/views/controls/label.h"
+#include "ui/views/layout/layout_constants.h"
+#include "ui/views/view.h"
+#include "ui/views/widget/widget.h"
+#include "ui/views/window/dialog_delegate.h"
+
+namespace arc {
+
+namespace {
+
+const int kRightColumnWidth = 210;
+const int kIconSize = 64;
+
+using ArcAppConfirmCallback =
+    base::Callback<void(const std::string& app_id, Profile* profile)>;
+
+class ArcAppDialogView : public views::DialogDelegateView,
+                         public AppIconLoaderDelegate {
+ public:
+  ArcAppDialogView(Profile* profile,
+                   AppListControllerDelegate* controller,
+                   const std::string& app_id,
+                   const base::string16& window_title,
+                   const base::string16& heading_text,
+                   const base::string16& confirm_button_text,
+                   const base::string16& cancel_button_text,
+                   ArcAppConfirmCallback confirm_callback);
+  ~ArcAppDialogView() override;
+
+  // Public method used for test only.
+  void ConfirmOrCancelForTest(bool confirm);
+
+ private:
+  // views::WidgetDelegate:
+  base::string16 GetWindowTitle() const override;
+  void DeleteDelegate() override;
+  ui::ModalType GetModalType() const override;
+
+  // views::View:
+  gfx::Size GetPreferredSize() const override;
+  void Layout() override;
+
+  // views::DialogDelegate:
+  base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;
+  bool Accept() override;
+
+  // AppIconLoaderDelegate:
+  void OnAppImageUpdated(const std::string& app_id,
+                         const gfx::ImageSkia& image) override;
+
+  // Constructs and shows the modal dialog widget.
+  void Show();
+
+  bool initial_setup_ = true;
+
+  views::ImageView* icon_view_ = nullptr;
+  views::Label* heading_view_ = nullptr;
+
+  std::unique_ptr<ArcAppIconLoader> icon_loader_;
+
+  Profile* const profile_;
+
+  AppListControllerDelegate* controller_;
+
+  gfx::NativeWindow parent_;
+
+  // Tracks whether |parent_| got destroyed.
+  std::unique_ptr<NativeWindowTracker> parent_window_tracker_;
+
+  const std::string app_id_;
+  const base::string16 window_title_;
+  const base::string16 confirm_button_text_;
+  const base::string16 cancel_button_text_;
+  ArcAppConfirmCallback confirm_callback_;
+
+  DISALLOW_COPY_AND_ASSIGN(ArcAppDialogView);
+};
+
+// Browertest use only. Global pointer of ArcAppDialogView which is shown.
+ArcAppDialogView* g_current_arc_app_dialog_view = nullptr;
+
+ArcAppDialogView::ArcAppDialogView(Profile* profile,
+                                   AppListControllerDelegate* controller,
+                                   const std::string& app_id,
+                                   const base::string16& window_title,
+                                   const base::string16& heading_text,
+                                   const base::string16& confirm_button_text,
+                                   const base::string16& cancel_button_text,
+                                   ArcAppConfirmCallback confirm_callback)
+    : profile_(profile),
+      controller_(controller),
+      app_id_(app_id),
+      window_title_(window_title),
+      confirm_button_text_(confirm_button_text),
+      cancel_button_text_(cancel_button_text),
+      confirm_callback_(confirm_callback) {
+  DCHECK(controller);
+  parent_ = controller_->GetAppListWindow();
+  if (parent_)
+    parent_window_tracker_ = NativeWindowTracker::Create(parent_);
+
+  icon_view_ = new views::ImageView();
+  icon_view_->SetImageSize(gfx::Size(kIconSize, kIconSize));
+  AddChildView(icon_view_);
+
+  heading_view_ = new views::Label(heading_text);
+  heading_view_->SetMultiLine(true);
+  heading_view_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+  heading_view_->SetAllowCharacterBreak(true);
+  AddChildView(heading_view_);
+
+  icon_loader_.reset(new ArcAppIconLoader(profile_, kIconSize, this));

[msw, 2016/11/30 23:26:57]

nit: add a comment like "The dialog will show once the icon is loaded."

[lgcheng, 2016/12/01 02:05:56]

Done.

+  icon_loader_->FetchImage(app_id_);
+}
+
+ArcAppDialogView::~ArcAppDialogView() {
+  DCHECK_EQ(this, g_current_arc_app_dialog_view);
+  g_current_arc_app_dialog_view = nullptr;
+}
+
+void ArcAppDialogView::ConfirmOrCancelForTest(bool confirm) {
+  if (confirm)
+    Accept();
+  else
+    Cancel();
+  this->GetWidget()->Close();

[msw, 2016/11/30 23:26:57]

nit: is this needed? if so, can you remove "this->"?

[lgcheng, 2016/12/01 02:05:56]

This is needed in test. Calling Accept() or Cancel() would not close the window.
The object is actually released in test teardown time and would lead to
DCHECK_EQ(this, g_current_arc_app_dialog_view) fail in deconstructor if I create
more than one ArcAppDialog in a single test.

Manual confirm from UI works correctly and object is deconstructed correctly
while I observe the logging in manual test.

this-> removed.

+}
+
+base::string16 ArcAppDialogView::GetWindowTitle() const {
+  return window_title_;
+}
+
+void ArcAppDialogView::DeleteDelegate() {
+  if (controller_)
+    controller_->OnCloseChildDialog();
+  DialogDelegateView::DeleteDelegate();
+}
+
+ui::ModalType ArcAppDialogView::GetModalType() const {
+  return ui::MODAL_TYPE_WINDOW;
+}
+
+gfx::Size ArcAppDialogView::GetPreferredSize() const {
+  int width = kRightColumnWidth;
+  width += kIconSize;
+  width += views::kButtonHEdgeMarginNew * 2;
+  width += views::kRelatedControlHorizontalSpacing;
+
+  int height = views::kPanelVertMargin * 2;
+  height += heading_view_->GetHeightForWidth(kRightColumnWidth);
+
+  return gfx::Size(width,
+                   std::max(height, kIconSize + views::kPanelVertMargin * 2));
+}
+
+void ArcAppDialogView::Layout() {
+  int x = views::kButtonHEdgeMarginNew;
+  int y = views::kPanelVertMargin;
+
+  heading_view_->SizeToFit(kRightColumnWidth);
+
+  if (heading_view_->height() <= kIconSize) {
+    icon_view_->SetBounds(x, y, kIconSize, kIconSize);
+    x += kIconSize;
+    x += views::kRelatedControlHorizontalSpacing;
+
+    heading_view_->SetX(x);
+    heading_view_->SetY(y + (kIconSize - heading_view_->height()) / 2);
+  } else {
+    icon_view_->SetBounds(x, y + (heading_view_->height() - kIconSize) / 2,
+                          kIconSize, kIconSize);
+    x += kIconSize;
+    x += views::kRelatedControlHorizontalSpacing;
+
+    heading_view_->SetX(x);
+    heading_view_->SetY(y);
+  }
+}
+
+base::string16 ArcAppDialogView::GetDialogButtonLabel(
+    ui::DialogButton button) const {
+  return button == ui::DIALOG_BUTTON_CANCEL ? cancel_button_text_
+                                            : confirm_button_text_;
+}
+
+bool ArcAppDialogView::Accept() {
+  confirm_callback_.Run(app_id_, profile_);
+  return true;
+}
+
+void ArcAppDialogView::OnAppImageUpdated(const std::string& app_id,
+                                         const gfx::ImageSkia& image) {
+  DCHECK_EQ(app_id, app_id_);
+
+  icon_view_->SetImage(image);

[msw, 2016/11/30 23:26:57]

nit: DCHECK(!image.isNull()); above.

[lgcheng, 2016/12/01 02:05:56]

Done.

+
+  if (initial_setup_)
+    Show();
+}
+
+void ArcAppDialogView::Show() {
+  initial_setup_ = false;
+
+  // Parent window is killed before icon is loaded.

[msw, 2016/11/30 23:26:57]

nit: "The parent window was killed before the icon was loaded."

[lgcheng, 2016/12/01 02:05:56]

Done.

+  if (parent_ && parent_window_tracker_->WasNativeWindowClosed()) {
+    Cancel();
+    DialogDelegateView::DeleteDelegate();
+    return;
+  }
+
+  if (controller_)
+    controller_->OnShowChildDialog();
+
+  g_current_arc_app_dialog_view = this;
+  constrained_window::CreateBrowserModalDialogViews(this, parent_)->Show();
+}
+
+}  // namespace
+
+void ShowArcAppUninstallDialog(Profile* profile,
+                               AppListControllerDelegate* controller,
+                               const std::string& app_id) {
+  ArcAppListPrefs* arc_prefs = ArcAppListPrefs::Get(profile);
+  DCHECK(arc_prefs);
+  std::unique_ptr<ArcAppListPrefs::AppInfo> app_info =
+      arc_prefs->GetApp(app_id);
+
+  if (!app_info)
+    return;
+
+  bool is_shortcut = app_info->shortcut;
+
+  base::string16 window_title = l10n_util::GetStringUTF16(
+      is_shortcut ? IDS_EXTENSION_UNINSTALL_PROMPT_TITLE
+                  : IDS_APP_UNINSTALL_PROMPT_TITLE);
+
+  base::string16 heading_text = base::UTF8ToUTF16(l10n_util::GetStringFUTF8(
+      is_shortcut ? IDS_EXTENSION_UNINSTALL_PROMPT_HEADING
+                  : IDS_ARC_APP_UNINSTALL_PROMPT_HEADING,
+      base::UTF8ToUTF16(app_info->name)));
+
+  base::string16 confirm_button_text = l10n_util::GetStringUTF16(
+      is_shortcut ? IDS_EXTENSION_PROMPT_UNINSTALL_BUTTON
+                  : IDS_EXTENSION_PROMPT_UNINSTALL_APP_BUTTON);
+
+  base::string16 cancel_button_text = l10n_util::GetStringUTF16(IDS_CANCEL);
+
+  new ArcAppDialogView(profile, controller, app_id, window_title, heading_text,
+                       confirm_button_text, cancel_button_text,
+                       base::Bind(UninstallArcApp));
+}
+
+bool IsArcAppDialogViewAliveForTest() {
+  return g_current_arc_app_dialog_view != nullptr;
+}
+
+bool CloseAppDialogViewAndConfirmForTest(bool confirm) {
+  if (!g_current_arc_app_dialog_view)
+    return false;
+
+  g_current_arc_app_dialog_view->ConfirmOrCancelForTest(confirm);
+  return true;
+}
+
+}  // namespace arc