third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js - Issue 2529743003: DevTools: Prevent autocompletion for empty input in ClassesPaneWidget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js

Issue 2529743003: DevTools: Prevent autocompletion for empty input in ClassesPaneWidget (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js b/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js

index 59556efb76b995024ba96d96121792e970b08719..c996daeec680c7a66390659003f5ab7a3a453964 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js

@@ -249,7 +249,7 @@ Elements.ClassesPaneWidget.ClassNamePrompt = class extends UI.TextPrompt {

this._classNamesPromise = null;

var selectedNode = UI.context.flavor(SDK.DOMNode);

- if (!selectedNode || (!prefix && !force && !expression))

+ if (!selectedNode || (!prefix && !force && !expression.trim()))

return Promise.resolve([]);

if (!this._classNamesPromise || this._selectedFrameId !== selectedNode.frameId())

« no previous file with comments | « no previous file | no next file » | no next file with comments »