Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js

Issue 2529743003: DevTools: Prevent autocompletion for empty input in ClassesPaneWidget (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @unrestricted 5 * @unrestricted
6 */ 6 */
7 Elements.ClassesPaneWidget = class extends UI.Widget { 7 Elements.ClassesPaneWidget = class extends UI.Widget {
8 constructor() { 8 constructor() {
9 super(); 9 super();
10 this.element.className = 'styles-element-classes-pane'; 10 this.element.className = 'styles-element-classes-pane';
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 * @param {string} expression 242 * @param {string} expression
243 * @param {string} prefix 243 * @param {string} prefix
244 * @param {boolean=} force 244 * @param {boolean=} force
245 * @return {!Promise<!UI.SuggestBox.Suggestions>} 245 * @return {!Promise<!UI.SuggestBox.Suggestions>}
246 */ 246 */
247 _buildClassNameCompletions(expression, prefix, force) { 247 _buildClassNameCompletions(expression, prefix, force) {
248 if (!prefix || force) 248 if (!prefix || force)
249 this._classNamesPromise = null; 249 this._classNamesPromise = null;
250 250
251 var selectedNode = UI.context.flavor(SDK.DOMNode); 251 var selectedNode = UI.context.flavor(SDK.DOMNode);
252 if (!selectedNode || (!prefix && !force && !expression)) 252 if (!selectedNode || (!prefix && !force && !expression.trim()))
253 return Promise.resolve([]); 253 return Promise.resolve([]);
254 254
255 if (!this._classNamesPromise || this._selectedFrameId !== selectedNode.frame Id()) 255 if (!this._classNamesPromise || this._selectedFrameId !== selectedNode.frame Id())
256 this._classNamesPromise = this._getClassNames(selectedNode); 256 this._classNamesPromise = this._getClassNames(selectedNode);
257 257
258 return this._classNamesPromise.then(completions => { 258 return this._classNamesPromise.then(completions => {
259 if (prefix[0] === '.') 259 if (prefix[0] === '.')
260 completions = completions.map(value => '.' + value); 260 completions = completions.map(value => '.' + value);
261 return completions.filter(value => value.startsWith(prefix)).map(completio n => ({title: completion})); 261 return completions.filter(value => value.startsWith(prefix)).map(completio n => ({title: completion}));
262 }); 262 });
263 } 263 }
264 }; 264 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698