Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: chrome/browser/ui/views/payments/payment_request_dialog.h

Issue 2529733002: [WebPayments] Move views-specific code to c/b/ui/views/ (Closed)
Patch Set: Implement ShowWebPaymentsDialog in TestBrowserWindow Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_request_dialog.h
diff --git a/chrome/browser/payments/ui/payment_request_dialog.h b/chrome/browser/ui/views/payments/payment_request_dialog.h
similarity index 64%
rename from chrome/browser/payments/ui/payment_request_dialog.h
rename to chrome/browser/ui/views/payments/payment_request_dialog.h
index 6834c11bccaa5a141047be02d6f5259ce2331388..dbb40b31225f5825e2bbfcb3475cad9c5abca5b5 100644
--- a/chrome/browser/payments/ui/payment_request_dialog.h
+++ b/chrome/browser/ui/views/payments/payment_request_dialog.h
@@ -2,19 +2,19 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_PAYMENTS_UI_PAYMENT_REQUEST_DIALOG_H_
-#define CHROME_BROWSER_PAYMENTS_UI_PAYMENT_REQUEST_DIALOG_H_
+#ifndef CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_DIALOG_H_
+#define CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_DIALOG_H_
-#include "components/payments/payment_request.mojom.h"
#include "ui/views/controls/label.h"
#include "ui/views/window/dialog_delegate.h"
namespace payments {
+class PaymentRequestImpl;
+
class PaymentRequestDialog : public views::DialogDelegateView {
public:
- explicit PaymentRequestDialog(
- payments::mojom::PaymentRequestClientPtr client);
+ explicit PaymentRequestDialog(PaymentRequestImpl* impl);
~PaymentRequestDialog() override;
// views::WidgetDelegate
@@ -27,7 +27,7 @@ class PaymentRequestDialog : public views::DialogDelegateView {
bool Cancel() override;
private:
- payments::mojom::PaymentRequestClientPtr client_;
+ PaymentRequestImpl* impl_; // Not owned.
please use gerrit instead 2016/11/28 15:16:41 Clearly describe the lifetime of PaymentRequestImp
anthonyvd 2016/11/28 16:12:18 Done. Totally agree with you. Added a comment, le
std::unique_ptr<views::Label> label_;
DISALLOW_COPY_AND_ASSIGN(PaymentRequestDialog);
@@ -35,4 +35,4 @@ class PaymentRequestDialog : public views::DialogDelegateView {
} // namespace payments
-#endif // CHROME_BROWSER_PAYMENTS_UI_PAYMENT_REQUEST_DIALOG_H_
+#endif // CHROME_BROWSER_UI_VIEWS_PAYMENTS_PAYMENT_REQUEST_DIALOG_H_

Powered by Google App Engine
This is Rietveld 408576698