Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 2529703002: Mus: Install SwapBuffersCompleted/VSync callbacks to DirectOutputSurface(Ozone) (Closed)

Created:
4 years ago by Fady Samuel
Modified:
4 years ago
Reviewers:
kylechar, jbauman, piman
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mus: Fix Capabilities and Install SwapBuffersCompleted/VSync callbacks DirectOutputSurface(Ozone) should be informed when a swap buffers is completed or when vsync parameters are updated so that it can update the compositor accordingly. We need to make sure that the callback is called on the Mus compositor thread. InProcessCommandBuffer calls these callbacks on the "origin" thread in this patch. Furthermore, InProcessContextProvider was faking Capabilities instead of grabbing them from InProcessContextProvider. This doesn't work on ozone platforms. BUG=668136 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/58b5a2252f651bc852b7afe57377e4f0f5a8bb91 Cr-Commit-Position: refs/heads/master@{#434285}

Patch Set 1 #

Patch Set 2 : Grab capabilities from the InProcessCommandBuffer instead of making them up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -55 lines) Patch
M cc/output/in_process_context_provider.cc View 1 1 chunk +1 line, -12 lines 0 comments Download
M gpu/ipc/gl_in_process_context.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/ipc/gl_in_process_context.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M gpu/ipc/in_process_command_buffer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/ipc/in_process_command_buffer.cc View 2 chunks +36 lines, -11 lines 0 comments Download
M services/ui/surfaces/direct_output_surface.h View 1 chunk +8 lines, -3 lines 0 comments Download
M services/ui/surfaces/direct_output_surface.cc View 4 chunks +16 lines, -17 lines 0 comments Download
M services/ui/surfaces/direct_output_surface_ozone.h View 1 chunk +2 lines, -4 lines 0 comments Download
M services/ui/surfaces/direct_output_surface_ozone.cc View 3 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 26 (18 generated)
Fady Samuel
4 years ago (2016-11-23 18:36:34 UTC) #4
kylechar
lgtm
4 years ago (2016-11-23 20:36:52 UTC) #12
Fady Samuel
+piman@ for gpu/ipc and cc. Thanks!
4 years ago (2016-11-23 20:40:37 UTC) #14
jbauman
lgtm
4 years ago (2016-11-23 22:13:23 UTC) #16
piman
lgtm
4 years ago (2016-11-23 22:18:24 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529703002/20001
4 years ago (2016-11-23 22:58:57 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-23 23:50:55 UTC) #24
commit-bot: I haz the power
4 years ago (2016-11-23 23:52:56 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/58b5a2252f651bc852b7afe57377e4f0f5a8bb91
Cr-Commit-Position: refs/heads/master@{#434285}

Powered by Google App Engine
This is Rietveld 408576698