Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2529663002: Revert of [heap] Refactor heap object iteration (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Refactor heap object iteration (patchset #6 id:100001 of https://codereview.chromium.org/2516303006/ ) Reason for revert: Breaks msan: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/12103 Original issue's description: > [heap] Refactor heap object iteration > > BUG= > > Committed: https://crrev.com/d094fa76f3dd0bb5fc3f4c669762aa97d88e0f76 > Cr-Commit-Position: refs/heads/master@{#41226} TBR=hpayer@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/1a4294b1811837e07cb5a9e8db0c2826f744aa9c Cr-Commit-Position: refs/heads/master@{#41230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -140 lines) Patch
M src/heap/array-buffer-tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 6 chunks +21 lines, -13 lines 0 comments Download
M src/heap/spaces.h View 13 chunks +126 lines, -87 lines 0 comments Download
M src/heap/spaces.cc View 4 chunks +10 lines, -19 lines 0 comments Download
M src/heap/spaces-inl.h View 3 chunks +7 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Achenbach
Created Revert of [heap] Refactor heap object iteration
4 years ago (2016-11-23 15:28:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2529663002/1
4 years ago (2016-11-23 15:28:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 15:28:35 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-23 15:28:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a4294b1811837e07cb5a9e8db0c2826f744aa9c
Cr-Commit-Position: refs/heads/master@{#41230}

Powered by Google App Engine
This is Rietveld 408576698