Prerender: Test that prefetch flags are set correctly on redirect.

chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_split.h"
 #include "base/task_scheduler/post_task.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/history/history_test_utils.h"
@@ skipping 12 matching lines @@
 #include "content/public/common/content_switches.h"
 #include "content/public/common/url_constants.h"
 #include "content/public/test/browser_test_utils.h"
 #include "net/base/escape.h"
 #include "net/dns/mock_host_resolver.h"
 #include "net/test/embedded_test_server/request_handler_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/l10n/l10n_util.h"
 
 using prerender::test_utils::CreateCountingInterceptorOnIO;
+using prerender::test_utils::CreatePrefetchOnlyInterceptorOnIO;
 using prerender::test_utils::DestructionWaiter;
 using prerender::test_utils::RequestCounter;
 using prerender::test_utils::TestPrerender;
 
 namespace prerender {
 
 // These URLs used for test resources must be relative with the exception of
 // |kPrefetchLoaderPath|.
 const char kPrefetchImagePage[] = "prerender/prefetch_image.html";
 const char kPrefetchJpeg[] = "prerender/image.jpeg";
@@ skipping 219 matching lines @@
 IN_PROC_BROWSER_TEST_F(NoStatePrefetchBrowserTest, Prefetch301Redirect) {
   RequestCounter script_counter;
   CountRequestFor(kPrefetchScript, &script_counter);
   PrefetchFromFile(
       "/server-redirect/?" +
           net::EscapeQueryParamValue(MakeAbsolute(kPrefetchPage), false),
       FINAL_STATUS_NOSTATE_PREFETCH_FINISHED);
   script_counter.WaitForCount(1);
 }
 
+// Checks that the load flags are set correctly for all resources in a 301
+// redirect chain.
+IN_PROC_BROWSER_TEST_F(NoStatePrefetchBrowserTest, Prefetch301LoadFlags) {
+  std::string redirect_path =
+      "/server-redirect/?" +
+      net::EscapeQueryParamValue(MakeAbsolute(kPrefetchPage), false);
+  GURL redirect_url = src_server()->GetURL(redirect_path);
+  GURL page_url = src_server()->GetURL(MakeAbsolute(kPrefetchPage));
+  RequestCounter redirect_counter;
+  content::BrowserThread::PostTask(
+      content::BrowserThread::IO, FROM_HERE,
+      base::Bind(&CreatePrefetchOnlyInterceptorOnIO, redirect_url,
+                 redirect_counter.AsWeakPtr()));

[pasko, 2016/11/23 16:47:29]

nit:

since we are waiting on the counter anyway, a weak pointer is not necessary,
wrapping with base::Unretained(&redirect_counter) should be sufficient.

It does not add much code/complexity to use a weak ptr, and there is some
flexibility in it, so I am ok either way, just fyi that this simpler way exists.

[mattcary, 2016/11/24 08:30:22]

I did it this way to be consistent with the other interceptors.

+  RequestCounter page_counter;
+  content::BrowserThread::PostTask(
+      content::BrowserThread::IO, FROM_HERE,
+      base::Bind(&CreatePrefetchOnlyInterceptorOnIO, page_url,
+                 page_counter.AsWeakPtr()));
+  PrefetchFromFile(redirect_path, FINAL_STATUS_NOSTATE_PREFETCH_FINISHED);
+  redirect_counter.WaitForCount(1);
+  page_counter.WaitForCount(1);
+}
+
 // Checks that a subresource 301 redirect is followed.
 IN_PROC_BROWSER_TEST_F(NoStatePrefetchBrowserTest, Prefetch301Subresource) {
   RequestCounter script_counter;
   CountRequestFor(kPrefetchScript, &script_counter);
   PrefetchFromFile(kPrefetchSubresourceRedirectPage,
                    FINAL_STATUS_NOSTATE_PREFETCH_FINISHED);
   script_counter.WaitForCount(1);
 }
 
 // Checks a client redirect is not followed.
@@ skipping 162 matching lines @@
 
   // Check that the URL that was prefetched is not in history.
   EXPECT_TRUE(std::find(urls.begin(), urls.end(), prefetched_url) ==
               urls.end());
 
   // The loader URL is the remaining entry.
   EXPECT_EQ(2U, urls.size());
 }
 
 }  // namespace prerender