Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 252963004: MacViews: Fix builds when use_aura XOR toolkit_views is TRUE. (Closed)

Created:
6 years, 7 months ago by tapted
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Visibility:
Public.

Description

MacViews: Fix builds when use_aura XOR toolkit_views is TRUE. Ozone has use_aura=1 and toolkit_views=0. MacViews has use_aura=0 and toolkit_views=1. Ensure these both link correctly. This is a follow-up to r266641 and r266283. BUG=366007 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/gfx/gfx.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
tapted
6 years, 7 months ago (2014-04-29 10:26:41 UTC) #1
dnicoara
lgtm
6 years, 7 months ago (2014-04-29 12:12:25 UTC) #2
tapted
6 years, 7 months ago (2014-04-29 12:27:33 UTC) #3
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 7 months ago (2014-04-29 12:27:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/252963004/1
6 years, 7 months ago (2014-04-29 12:27:45 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 12:56:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-29 12:56:42 UTC) #7
tapted
On 2014/04/29 12:56:42, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 7 months ago (2014-04-29 13:03:49 UTC) #8
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 7 months ago (2014-04-29 13:03:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/252963004/1
6 years, 7 months ago (2014-04-29 13:04:09 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 21:43:44 UTC) #11
Message was sent while issue was closed.
Change committed as 266965

Powered by Google App Engine
This is Rietveld 408576698