Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 252963003: Revert of Adds back some debugging code (Closed)

Created:
6 years, 7 months ago by robliao
Modified:
6 years, 7 months ago
Reviewers:
flackr, sky
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank, awong
Visibility:
Public.

Description

Revert of Adds back some debugging code (https://codereview.chromium.org/257023002/) Reason for revert: Breaks ash_unittests FullscreenWindow VideoDetectorTest.FullscreenWindow (run #1): [ RUN ] VideoDetectorTest.FullscreenWindow [21122:21122:0428/162209:675210655:WARNING:cras_audio_handler.cc(472)] Audio input allowed by policy, sets input id=0x0 mute=false [21122:21122:0428/162209:675210697:WARNING:cras_audio_handler.cc(508)] SetInputMuteInternal sets active input device id=0x0 mute=0 [21122:21122:0428/162209:675210737:WARNING:cras_audio_handler.cc(429)] SetupAudioInputState for active device id=0x2715 mute=0 [21122:21122:0428/162209:675210757:WARNING:cras_audio_handler.cc(508)] SetInputMuteInternal sets active input device id=0x2715 mute=0 Xlib: extension "RANDR" missing on display ":9". Xlib: extension "RANDR" missing on display ":9". [21122:21122:0428/162209:675250984:FATAL:window_observer.cc(18)] Check failed: 0 == observing_ (0 vs. 1) Original issue's description: > Adds back some debugging code > > We're getting another crash that looks like an observer is being > destroyed before removing itself. > > BUG=365364 > TEST=none > R=flackr@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266681 TBR=flackr@chromium.org,sky@chromium.org NOTREECHECKS=true NOTRY=true BUG=365364 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266691

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -53 lines) Patch
M ui/aura/aura.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/window.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/aura/window_observer.h View 2 chunks +1 line, -18 lines 0 comments Download
D ui/aura/window_observer.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M ui/aura/window_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
robliao
Created Revert of Adds back some debugging code
6 years, 7 months ago (2014-04-28 23:41:06 UTC) #1
robliao
6 years, 7 months ago (2014-04-28 23:41:23 UTC) #2
robliao
The CQ bit was checked by robliao@chromium.org
6 years, 7 months ago (2014-04-28 23:41:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/252963003/1
6 years, 7 months ago (2014-04-28 23:41:53 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 23:43:12 UTC) #5
Message was sent while issue was closed.
Change committed as 266691

Powered by Google App Engine
This is Rietveld 408576698