Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 252963002: Revert of Touch emulator: overwrite timestamps from mouse event with current time. (Closed)

Created:
6 years, 7 months ago by Nico
Modified:
6 years, 7 months ago
Reviewers:
jdduke (slow), dgozman
CC:
chromium-reviews, jam, jdduke+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Revert of Touch emulator: overwrite timestamps from mouse event with current time. (https://codereview.chromium.org/250923005/) Reason for revert: Somewhat speculative; looks like this caused TouchEmulatorTest failures on valgrind: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28tsan%29%283%29/builds/11052 TouchEmulatorTest.Pinch: ../../content/browser/renderer_host/input/touch_emulator_unittest.cc:254: Failure Value of: ExpectedEvents() Actual: "TouchEnd GestureFlingStart" Expected: "TouchEnd GestureScrollEnd" etc Original issue's description: > Touch emulator: overwrite timestamps from mouse event with current time. > > On some platfroms, mouse events come with a bad timestamp, which leads to > awkward time-dependent gestures. For example, fling animation may be almost > instant. > Using base::TimeTicks::Now() is good enough for emulation purposes, because > emulator spawns new events itself. > > BUG=367156 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266548 TBR=jdduke@chromium.org,dgozman@chromium.org NOTREECHECKS=true NOTRY=true BUG=367156 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266610

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M content/browser/renderer_host/input/touch_emulator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_emulator.cc View 2 chunks +1 line, -11 lines 0 comments Download
M content/browser/renderer_host/input/touch_emulator_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
Created Revert of Touch emulator: overwrite timestamps from mouse event with current time.
6 years, 7 months ago (2014-04-28 18:26:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/252963002/1
6 years, 7 months ago (2014-04-28 18:28:38 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 18:30:01 UTC) #3
Message was sent while issue was closed.
Change committed as 266610

Powered by Google App Engine
This is Rietveld 408576698