Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4072)

Unified Diff: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h

Issue 2529603004: [Offline Pages] Expanding event logger to be used by harness. (Closed)
Patch Set: more comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h
diff --git a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h
index e860143937bd70dd2a6b537d65f0ad060b65a0e1..627e69ec2a167a3fbe183ab1c015de2a939418ee 100644
--- a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h
+++ b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h
@@ -11,6 +11,7 @@
#include "base/macros.h"
#include "components/offline_pages/background/request_coordinator.h"
#include "components/offline_pages/background/request_notifier.h"
+#include "components/offline_pages/offline_event_logger.h"
#include "components/offline_pages/offline_page_model.h"
namespace content {
@@ -25,7 +26,8 @@ namespace android {
* Bridge for exposing native implementation which are used by evaluation.
*/
class OfflinePageEvaluationBridge : public OfflinePageModel::Observer,
- public RequestCoordinator::Observer {
+ public RequestCoordinator::Observer,
+ public OfflineEventLogger::Client {
public:
static bool Register(JNIEnv* env);
static std::unique_ptr<KeyedService> GetTestingRequestCoordinator(
@@ -50,6 +52,10 @@ class OfflinePageEvaluationBridge : public OfflinePageModel::Observer,
RequestNotifier::BackgroundSavePageResult status) override;
void OnChanged(const SavePageRequest& request) override;
+ // OfflineEventLogger::Client implementation.
+ void CustomLog(const std::string& message) override;
+
+ // Gets all pages in offline page model.
void GetAllPages(JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
const base::android::JavaParamRef<jobject>& j_result_obj,

Powered by Google App Engine
This is Rietveld 408576698