Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: components/offline_pages/offline_event_logger_unittest.cc

Issue 2529603004: [Offline Pages] Expanding event logger to be used by harness. (Closed)
Patch Set: Adding tests and fix build issue. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_event_logger_unittest.cc
diff --git a/components/offline_pages/offline_event_logger_unittest.cc b/components/offline_pages/offline_event_logger_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7e1bfa431a4ec51165c98755f8ed24261a0413a3
--- /dev/null
+++ b/components/offline_pages/offline_event_logger_unittest.cc
@@ -0,0 +1,54 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/offline_pages/offline_event_logger.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace offline_pages {
+
+namespace {
+const char kMessage[] = "Message is 42";
+const int kTimeLength = 21;
+
+class EventLoggerTestClient : public OfflineEventLogger::Client {
+ public:
+ void CustomLog(const std::string& message) override {
+ last_log_message_ = message;
+ }
+
+ const std::string& last_log_message() { return last_log_message_; }
+
+ private:
+ std::string last_log_message_;
+};
+
+} // namespace
+
+TEST(OfflineEventLoggerTest, SettingClientEnableLogging) {
+ OfflineEventLogger logger;
+ EventLoggerTestClient client;
+ logger.SetClient(&client);
+ EXPECT_TRUE(logger.GetIsLogging());
+}
+
+TEST(OfflineEventLoggerTest, SettingClientAndLog) {
+ OfflineEventLogger logger;
+ EventLoggerTestClient client;
+ logger.SetClient(&client);
+ std::vector<std::string> log;
fgorski 2016/12/05 17:22:18 move declaration to where it is used.
romax 2016/12/05 19:42:27 Done.
+
+ logger.SetIsLogging(true);
+ for (size_t i = 0; i < kMaxLogCount + 1; ++i) {
fgorski 2016/12/05 17:22:18 nit: remove {} Also, I don't believe putting the
romax 2016/12/05 19:42:27 Done.
+ logger.RecordActivity(kMessage);
+ }
+ logger.GetLogs(&log);
+
+ EXPECT_EQ(kMaxLogCount, log.size());
+ EXPECT_EQ(client.last_log_message(), log[kMaxLogCount - 1]);
+ EXPECT_EQ(std::string(kMessage),
+ client.last_log_message().substr(kTimeLength));
+}
+
+} // namespace offline_pages

Powered by Google App Engine
This is Rietveld 408576698