[Offline Pages] Expanding event logger to be used by harness.

chrome/browser/android/offline_pages/evaluation/evaluation_test_scheduler.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/evaluation/evaluation_test_scheduler.h"
 
 #include "base/logging.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/browser/android/offline_pages/request_coordinator_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "components/offline_pages/background/device_conditions.h"
 #include "components/offline_pages/background/request_coordinator.h"
+#include "components/offline_pages/offline_event_logger.h"
 #include "net/base/network_change_notifier.h"
 
 namespace offline_pages {
 
 namespace android {
 
 namespace {
 
 void StartProcessing();
 
@@ skipping 20 matching lines @@
   Profile* profile = ProfileManager::GetLastUsedProfile();
   RequestCoordinator* coordinator =
       RequestCoordinatorFactory::GetInstance()->GetForBrowserContext(profile);
   coordinator->GetAllRequests(base::Bind(&GetAllRequestsDone));
 }
 
 }  // namespace
 
 void EvaluationTestScheduler::Schedule(
     const TriggerConditions& trigger_conditions) {
+  Profile* profile = ProfileManager::GetLastUsedProfile();
+  if (!coordinator_) {

[fgorski, 2016/11/30 17:30:47]

Since you only use this here, I don't think you need this as a field. Variable
should do as well.

[romax, 2016/12/01 01:47:52]

Acknowledged.
yeah but this schedule might be called many times during a evaluation run, so
i'd like to keep it as a member variable.

+    coordinator_ =
+        RequestCoordinatorFactory::GetInstance()->GetForBrowserContext(profile);

[fgorski, 2016/11/30 17:30:47]

what if your profile is null here, or incognito, and you are setting
coordinator_ to null too?

[romax, 2016/12/01 01:47:52]

I didn't think about this case since this scheduler is only used in test which
would not have a null profile. And I don't think I have a way to handle it
properly, maybe just let it crash... I'll add an assert here.

[fgorski, 2016/12/01 21:42:52]

Go ahead.

[romax, 2016/12/02 01:57:48]

Done.

+  }
+  coordinator_->GetLogger()->RecordActivity(OFFLINE_LOG_TAG +
+                                            "Start schedule!");
   base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
                                                 base::Bind(&StartProcessing));
 }
 
 void EvaluationTestScheduler::BackupSchedule(
     const TriggerConditions& trigger_conditions,
     long delay_in_seconds) {}
 
 void EvaluationTestScheduler::Unschedule() {}
 
 void EvaluationTestScheduler::ImmediateScheduleCallback(bool result) {
   base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
                                                 base::Bind(&StartProcessing));
 }
 
 }  // namespace android
 }  // namespace offline_pages